1903329 - Ship Float16Array

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Dan Minor [:dminor]]

I'm planning to ship Float16Array in Firefox 129.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1903329 - Ship Float16Array; r=nbp!

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1903329 - Update test expectations; r=peterv!

Depends on D214259

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1903329 - Update non262 TypedArray tests; r=nbp!

Depends on D214260

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfe7f0ee5fa7
Ship Float16Array; r=nbp
https://hg.mozilla.org/integration/autoland/rev/2c1074b3e0f1
Update test expectations; r=peterv
https://hg.mozilla.org/integration/autoland/rev/e17166677489
Update non262 TypedArray tests; r=nbp

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing wpt failures on Android.

• Backout link
• Push with failures
• Failure Log

L.E. There are more failures related with your changeset and on multiple platforms: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=f8b80c380cc2c238ca9c742801d7c30f881feca8&searchStr=wpt&selectedTaskRun=eFqCiNHfQluPgR5MbK19fw.0

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1903329 - Enable Float16 in JSStructuredCloneReader::readTypedArray; r=nbp!

Depends on D214261

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1903329 - Update wpt expectations; r=nbp!

Depends on D214596

Comment 8

[Dan Minor [:dminor]]

I think I've got the wpt failures sorted out: https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=bdtwpecxRRyJElAx_F5KgQ.0&revision=f96c05d167da45aa4b7479d13294aebcfca7781d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f098562d31b8
Ship Float16Array; r=nbp
https://hg.mozilla.org/integration/autoland/rev/8cf04c424f91
Update test expectations; r=peterv
https://hg.mozilla.org/integration/autoland/rev/fd17e226fbe8
Update non262 TypedArray tests; r=nbp
https://hg.mozilla.org/integration/autoland/rev/a9a0cdc5a852
Enable Float16 in JSStructuredCloneReader::readTypedArray; r=nbp
https://hg.mozilla.org/integration/autoland/rev/04e9c2dafe58
Update wpt expectations; r=nbp

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f098562d31b8
https://hg.mozilla.org/mozilla-central/rev/8cf04c424f91
https://hg.mozilla.org/mozilla-central/rev/fd17e226fbe8
https://hg.mozilla.org/mozilla-central/rev/a9a0cdc5a852
https://hg.mozilla.org/mozilla-central/rev/04e9c2dafe58

Comment 11

[Donal Meehan [:dmeehan]]

:dminor anything you want to nominate for a release note?

Comment 12

[Dan Minor [:dminor]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This adds a new variety of typed array that is particularly useful for transferring data to the GPU for things like graphics and ai models.
[Affects Firefox for Android]:
[Suggested wording]: Float16Array typed arrays are now supported, along with new DataView methods for reading and setting Float16 values, and a Math.f16round() static method that can be used to round numbers to 16 bits. The new type is useful for sharing data with a GPU, in particular for use cases where it makes sense to trade off precision for memory consumption.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Float16Array

Comment 13

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx129 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx129 release notes

Comment 14

[Hamish Willee]

FF129 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/34697. Mostly just release note, removing from experimental features and compatibility data. Docs themselves already up to date.