1903346 - Migrate Focus away from Play Core library

Status: RESOLVED FIXED

(Focus :: General, task, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

Per the email we just received from Google:

com.google.android.play:core has added this note for core:1.10.3:
Update your Play Core Maven dependency to an Android 14 compatible version! Your current Play Core library is incompatible with targetSdkVersion 34 (Android 14), which introduces a backwards-incompatible change to broadcast receivers to improve user security. As a reminder, from August 31, Google Play requires all new app releases to target Android 14. Update to the latest Play Core library version dependency to avoid app crashes: https://developer.android.com/guide/playcore#playcore-migration

We only use it for the Review component and Fenix was already migrated away. This is probably trivial to fix.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=5d1960a1d7712574dbc8dc1adda8e7a3a58825e4

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1903346 - Migrate the Play In-App Review library to the AC dependencies plugin.

Comment 3

[Jonathan Almeida [:jonalmeida]]

STR:

• Open the app three times to trigger the app review prompt.

Expected:

• The review prompt opens.

Actual:

• Don't crash?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/880172270605
Migrate the Play In-App Review library to the AC dependencies plugin. r=android-reviewers,jonalmeida

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/880172270605

Comment 6

[Lorand Janos]

Hi,
I did verify this issue, and while there is no crash happening after the third opening of the app, the review prompt doesn't open either. (However I couldn't find Focus Nightly on Playstore if that is needed, I downloaded it from here and here).

Devices used:

• Pixel 7 (Android 14)
• Pixel 7 (Android 15, Beta 2)
• Samsung Galaxy S23 Ultra (Android 14)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

To access Focus Nightly from the Play Store, you need to join the Google Group for it first, then sign up to be a tester.
https://groups.google.com/g/firefox-focus-pre-release
https://play.google.com/apps/testing/org.mozilla.focus.nightly

I personally saw the prompt on my first launch of Focus Nightly a couple days ago after getting the update, FWIW.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

The other option may be manually changing the system time forward by 90 days to trigger it.

Comment 9

[Lorand Janos]

Thanks for the additional info Ryan,
I managed to get in the Focus Nightly group, and I got the latest Focus Nightly build to download from the Playstore. (AS: 129.20240618050333).
However I still couldn't activate the review prompt, most probably still an error on my side, if there is any extra setting needed or some other app interferes.
I tried triggering it by opening the app three times, and also tried the 90 day time set ahead version, still no review prompt displayed. Even with and without a VPN set to US.

Tested devices:

• Samsung Galaxy S23 Ultra (Android 14).
• Pixel 7 (Android 15, Beta 2).

Comment 10

[Jonathan Almeida [:jonalmeida]]

Hey Lorand, I was able to verify this fix myself but don't worry, you are probably not doing anything wrong here. The Play Store sometimes rate limits the calls we make. For example, after verifying the app review works, trying to do it again after uninstalling and opening the app three times did not show the app review prompt again. ¯\_(ツ)_/¯

Device information

• Focus version: 127
• Android device model: Samsung S21
• Android OS version: 14

Comment 11

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 9408223 [details]
Bug 1903346 - Migrate the Play In-App Review library to the AC dependencies plugin.

Beta/Release Uplift Approval Request

• User impact if declined: This is a third party dependency upgrade that will help us remove a warning in the Play Console requesting us to upgrade. No user impact.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: No, because this is difficult to verify if you have used a device that has previously seen the app review prompt or the device is being rate limited by the Play Store.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We have tested this locally.
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9408223 [details]
Bug 1903346 - Migrate the Play In-App Review library to the AC dependencies plugin.

Approved for 128.0rc2.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/8af010d54b5b