1903352 - SVG attribute values should not be zoomed

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Philip Rogers]

Attachment: svg_zoom_attribute_value.html

Steps to reproduce:

Gecko recently implemented the CSS zoom property (https://bugzilla.mozilla.org/show_bug.cgi?id=390936), but zoom is incorrectly reflected in SVG attribute values. Like computed style, zoom should not be reflected in SVG attributes. One reason for this is to support round-tripping.

Actual results:

The attached testcase displays:
svg width attribute value: 200
rect width attribute value: 50

Expected results:

The attached testcase should display (chromium, webkit):
svg width attribute value: 100
rect width attribute value: 25

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::SVG' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1899695

:emilio, since you are the author of the regressor, bug 1899695, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=91689373bbb0af1da282bb034445328b0c0e9a11

Comment 4

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=25c87a741a66bd08e1783b3dfb8de5978b014c4a

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Seems robert is on it, thanks!

Comment 6

[Robert Longson [:longsonr]]

Attachment: Bug 1903352 - SVG attribute values should not be zoomed r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/031c8a5d110b
SVG attribute values should not be zoomed r=emilio

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46839 for changes under testing/web-platform/tests

Comment 9

[Serban Stanca [:SerbanS]]

Backed out as requested for causing android failures.

• Backout link

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=8c321953dc16312a0e92784a12828abcfcce55eb

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a19ddb66a26
SVG attribute values should not be zoomed r=emilio

Comment 13

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1a19ddb66a26

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:longsonr, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 17

[Robert Longson [:longsonr]]

Comment on attachment 9408459 [details]
Bug 1903352 - SVG attribute values should not be zoomed r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: SVG DOM does not work correctly in the presence of CSS zoom
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: There's a testcase in this bug
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): We seem to have had quite a few problems with csszoom regressions with websites assuming things they shouldn't.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9408459 [details]
Bug 1903352 - SVG attribute values should not be zoomed r=emilio

Approved for 128.0b7.

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c9c557bf5edf