1903353 - [wpt-sync] Sync PR 46814 - Add tests for custom properties that use CSS-wide keywords

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46814 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46814
Details from upstream follow.

Roman Komarov <[e-mail]> wrote:

Add tests for custom properties that use CSS-wide keywords

After encountering several inconsistencies in how custom properties use CSS-wide keywords, I did an extensive testing for most of the cases I could think of (CodePen), and decided to add these as tests.

When I am testing it, Chrome succeeds in all cases, Firefox fails in 5 of them, and Safari TP in 8 of them.

Relevant specs:

• CSS Custom Properties for Cascading Variables Module Level 1, specifically this part (among some others):

  The CSS-wide keywords can be used in custom properties, with the same meaning as in any another property.

• CSS Values and Units Module Level 3 defining initial, inherit and unset

• CSS Cascading and Inheritance Level 4 defining revert

• CSS Cascading and Inheritance Level 5 defining revert-layer

There were a couple of disjointed tests for two of the assertions that I found (one, two), but I decided that it won't hurt to have those duplicate in one test file for all the CSS-wide keywords.

I also tested many various permutations, including some obvious ones, and this was good, as some of the failures I found were not obvious, like Firefox failing with two cases for registered properties with initial and inherit values.

I did find only one bug related to the failures I found: https://bugs.webkit.org/show_bug.cgi?id=271136 — there might be others, but I am planning to fill separate bugs for Firefox and Safari anyway. I will update this text when I will do so.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e931155c55f8f9bc4e0bff7f197803d860a83a0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 30 subtests

Status Summary

Firefox

OK : 1
PASS : 25
CRASH: 1
FAIL : 5

Chrome

OK : 1
PASS : 30

Safari

OK : 1
PASS : 22
FAIL : 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Crashes

• /css/css-variables/variable-css-wide-keywords.html [wpt.fyi]: CRASH [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub]

Firefox-only Failures

• /css/css-variables/variable-css-wide-keywords.html [wpt.fyi]
  • initial as a var() fallback for an inheriting registered custom property: FAIL
  • inherit as a var() fallback for a non-inheriting registered custom property: FAIL
  • revert-layer as a var() fallback for an inheriting registered custom property: FAIL

New Tests That Don't Pass

• /css/css-variables/variable-css-wide-keywords.html [wpt.fyi]: CRASH [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: OK, Safari: OK)
  • revert-layer as a var() fallback for an unregistered custom property: FAIL (Chrome: PASS, Safari: FAIL)
  • initial as a var() fallback for an inheriting registered custom property: FAIL (Chrome: PASS, Safari: PASS)
  • inherit as a var() fallback for a non-inheriting registered custom property: FAIL (Chrome: PASS, Safari: PASS)
  • revert-layer as a var() fallback for a non-inheriting registered custom property: FAIL (Chrome: PASS, Safari: FAIL)
  • revert-layer as a var() fallback for an inheriting registered custom property: FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92aba572cbac
[wpt PR 46814] - Add tests for custom properties that use CSS-wide keywords, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b1f99f8b8cbc
[wpt PR 46814] - Update wpt metadata, a=testonly

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/92aba572cbac
https://hg.mozilla.org/mozilla-central/rev/b1f99f8b8cbc