1903359 - [Debug Drawer] Set a maximum width of the drawer

Status: NEW

(Firefox for Android :: Tooling, task, P3)

Description

[Noah Bond [:007]]

Currently, the Debug Drawer will expand to almost the entire screen, even on large devices. We should instead give it a maximum width of ~400-600 so the drawer layouts are not stretched, and the rest of the app can be still be viewed.

Comment 1

[Noah Bond [:007]]

Attachment: Bug 1903359 - Part 1 - Add `Material3` dependency

Comment 2

[Noah Bond [:007]]

Attachment: Bug 1903359 - Part 2 - Set a maximum drawer width and migrate Debug Drawer to use Material 3's `ModalNavigationDrawer` + `ModalDrawerSheet`

Comment 3

[Noah Bond [:007]]

Attachment: Bug 1903359 - Part 3 - Migrate the rest of the Debug Drawer to Material3

Comment 4

[Noah Bond [:007]]

Attachment: Bug 1903359 - Part 4 - Migrate `FirefoxTheme` + `AcornLayout` to Material3

Comment 5

[Noah Bond [:007]]

Per a comment on the Part 1 patch adding the Material 3 dependency:

A proper fix for this must be deferred until one of two things:

1. We are ready to migrate ALL of Fenix to Material 3.
   • The comment linked above summarizes this best, but, TLDR, our design system is based off of Material 2, and we'd need that migrated to Material 3 before we even consider moving Fenix over to that library.
2. We decide to migrate the Debug Drawer from a Drawer UI element to a Bottom Sheet UI element.
   • If we choose to make the Debugging UI a bottom sheet instead, we'll have some more flexibility over its design, since the BottomSheet Composable is not nearly as rigid as the Drawer Composable.

Comment 6

[Noah Bond [:007]]

I am abandoning the patches per comment #5