1903403 - Do not reject cookies containing %x9

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect, P2)

Description

[edgul]

As seen in the attributes/attributes-ctl.sub.html WPT we are failing the test Cookie with %x9 after Secure attribute is handled correctly. Let's fix this.

Comment 1

[edgul]

Oops, %x9 is HTAB and the spec doesn't require rejection. Maybe we just want to update the WPTs here?

Comment 2

[Andrea Marchesini [:baku]]

The WPTs are already up-to-date. We can simply close this bug. See:

• name-ctl.html: https://searchfox.org/mozilla-central/source/testing/web-platform/tests/cookies/name/name-ctl.html#24,43
• attributes-ctl.sub.html: https://searchfox.org/mozilla-central/source/testing/web-platform/tests/cookies/attributes/attributes-ctl.sub.html#24-25,90
• value-ctl.html: https://searchfox.org/mozilla-central/source/testing/web-platform/tests/cookies/value/value-ctl.html#21-22,24,43

Comment 3

[Andrea Marchesini [:baku]]

Actually, our implementation is still broken because of this: https://searchfox.org/mozilla-central/source/netwerk/cookie/CookieCommons.cpp#210

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1903403 - Do not reject cookies containing %x9, r?edgul

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/249cf582a8cd
Do not reject cookies containing %x9, r=cookie-reviewers,valentin

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/249cf582a8cd