1903473 - "about:about" contains "about:config" and "about:addons" but they don't work

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Comment 1

[Artemka]

There is a bug in Firefox and Firefox Focus for Android

Comment 2

[[:owlish] 🦉 PST]

Hi Artemka, thank you for filing the bug! Those pages are not supposed to work in our release browsers, they are only exposed in Nightly. Are you experiencing this in Nightly or release Firefox?

Comment 3

[Artemka]

The problem is different, why are they then displayed in the release versions?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:owlish, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Tom S]

You probably want to use nsIAboutModule::HIDE_FROM_ABOUTABOUT when defining the the "config" module in non-Nightly Fenix: https://searchfox.org/mozilla-central/rev/956f21594f3178f75c3a1c278980e112a65eb19d/docshell/base/nsAboutRedirector.cpp#101-102

Comment 6

[Polly McEldowney [:pollymce]]

hi owlish! would you be ok to add a bit more info on how to fix this please?
I think for a first bug, it could use a bit more explanation at the level of which lines to add to which files!

Comment 7

[Thinker Li [:sinker]]

Hi Owlish, right now, in spite of they are showing on the about:about page, the about:addons page is not available on fenix. On the other side, about:config is always available even about:about doesn't show it. To fix this bug properly, about:addons should be removed from about:about of fenix no matter nightly or no, or get the page back for fenix nightly. For about:config, I think it should be removed from about:about, but users should be able to access it by typing the URL manually.
WDYT?!!

Comment 8

[Thinker Li [:sinker]]

Attachment: Bug 1903473 - Remove about:addons and about:config from about:about. r?#android-reviewers

With fenix, "about:config" and "about:about" are supposed to be
disable on non-nightly builds. Here, we remove "abouc:config" from the
"about:about" page for non-nightly builds. "about:addons" has been
disabled completely for fenix, no mater it is nightly or not.

Even "about:config" has been removed from the "about:about" page, but
users still can access it by typing it's URL manually.

Comment 9

[Thinker Li [:sinker]]

https://treeherder.mozilla.org/jobs?repo=try&revision=c1d6ad3abe9f587f8bbc310b0fe9df95af179b58

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c20953c57262
Remove about:addons and about:config from about:about. r=geckoview-reviewers,owlish

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c20953c57262