1903483 - Simplify nsFrameList::EmptyList() allocation

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

See the patch for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1903483 - Simplify nsFrameList::EmptyList() allocation. r?#layout

Bug 729519 [1] made the empty frame list be allocated in the
.rodata (read-only) section. However, the setup can be simplified.

To verify that sEmptyList is still allocated in the .rodata section, I used
the following steps on my local Linux build:

1. Move nsFrameList.cpp in moz.build from UNIFIED_SOURCES to SOURCES.
2. Run objdump -x $(OBJDIR)/layout/generic/nsFrameList.o | grep sEmptyList.
3. Verify that the output sEmptyList has .rodata. The objdump output looks
   like this:

0000000000000038 g     O .rodata	0000000000000010 .hidden _ZN11nsFrameList10sEmptyListE

[1] Specifically, this commit:
https://hg.mozilla.org/mozilla-central/rev/c320c5821f98

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdf8c138d840
Simplify nsFrameList::EmptyList() allocation. r=layout-reviewers,emilio

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cdf8c138d840