1903496 - Show requests for file urls loaded by the page (images, stylesheet, script)

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task)

Description

[Julian Descottes [:jdescottes]]

Attachment: missing_file_requests.zip

Bug 1870580 added basic support for file URLs in the netmonitor. We now show the initial request for a navigation to a data URL.
However if the page is loading resources via file urls, the requests will not be listed.

STRs:

• unzip the attachment
• load index html directly as a file in Firefox
• open DevTools > Netmonitor
• reload

ER: Should show requests for the page, the script, the stylesheet, the image
AR: Only shows the request for the page

Note that we have a possibly similar issue for data URLs (bug 1903060), where resources are loaded in content, and we only get the notification in content processes. In that case the solutions are either to bubble the notification from content to parent on the platform side, or to observe directly in content processes on DevTools/BiDi side. It might also be the case here, but we should first check if we get notifications at all for those file requests.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1903496 - [devtools] Add proper support for file requests in netmonitor

Depends on D230649

Will add a test in the next revision.
This brings the file requests on par with data requests.
The response tab for those requests should now be properly populated.
The same data can be expected on file network events as on regular ones
so we no longer need to special case it.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1903496 - [devtools] Exclude file channels for chrome and resource schemes from content toolboxes

Depends on D230650
We cannot rely on the triggering principal to filter out chrome://
and resource:// file channels so explicitly check the originalURI

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1903496 - [devtools] Add tests for file URL in netmonitor

Depends on D230656

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/588e1420582e
[devtools] Add proper support for file requests in netmonitor r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/3d6b102033a1
[devtools] Exclude file channels for chrome and resource schemes from content toolboxes r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/f67ce1500d99
[devtools] Add tests for file URL in netmonitor r=devtools-reviewers,bomsy

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/588e1420582e
https://hg.mozilla.org/mozilla-central/rev/3d6b102033a1
https://hg.mozilla.org/mozilla-central/rev/f67ce1500d99