1903569 - Asses impact of the new Data sync foreground service timeout behavior when targeting Android 15

Status: RESOLVED FIXED

(Firefox for Android :: Downloads, task, P1)

Description

[Mihai Adrian Carare [:mcarare]]

https://developer.android.com/about/versions/15/behavior-changes-15

Data sync foreground services are allowed to run only 6 hours per 24 h period.
This would apply to our downloads service.

An alternative would be migrating to an alternative API: https://developer.android.com/about/versions/15/changes/datasync-migration

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Accounts and Sync' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mihai Adrian Carare [:mcarare]]

This note points to this potentially not being an issue for the downloads service, the only one with dataSync service type in our apps:

Note: The 6-hour time limit is shared by all of an app's dataSync foreground services. For example, if an app runs a dataSync service for four hours, then starts a different dataSync service, that second service will only be allowed to run for two hours. However, if the user brings the app to the foreground, the timer resets and the app has 6 hours available.

Comment 3

[Mihai Adrian Carare [:mcarare]]

The note above limits the scope of this issue to making sure the download service calls stopSelf when it reaches timeout. The other improvements, perhaps also including migrating to another API will be considered part of 1904019.

Comment 4

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1903569 - Call stopSelf on datasync service timeout.

This avoids app crashing with RemoteServiceException when timeout is reached.
See https://developer.android.com/about/versions/15/behavior-changes-15#datasync-timeout.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/281b8f1894b9
Call stopSelf on datasync service timeout. r=android-reviewers,rsainani

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/281b8f1894b9