1903583 - rust_minidump_writer_linux and Breakpad disagree on the alignment of the context structure on Android/AArch64

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Gabriele Svelto [:gsvelto]]

I noticed this issue by using debug builds w/ recent versions of the Rust compiler. copy_nonoverlapping() now checks if the source and destination pointers have the same alignment constraints, and this causes crash tests to fail with an assertion because Breakpad only aligns that structure to 8 bytes instead of the 16 that Rust expects. That's unsurprising because Breakpad declares the context as a char array without any specific alignment requirements. Setting the proper alignment should be sufficient to solve this issue.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1903583 - Enforce the same alignment for the crash context across C++ and Rust r=afranchuk

Also replace core::ptr::* uses with the std::ptr::* equivalents.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02caddd04031
Enforce the same alignment for the crash context across C++ and Rust r=afranchuk

Comment 3

[Cristian Tuns]

Backed out for causing build bustages with rust_minidump_writer_linux

• Backout link
• Push with failures
• Failure Log
• Failure line: error[E0658]: use of unstable library feature 'offset_of'
  error: could not compile rust_minidump_writer_linux (lib) due to 4 previous errors
  gmake[4]: *** [/builds/worker/checkouts/gecko/config/makefiles/rust.mk:498: force-cargo-library-build] Error 101

Comment 4

[Gabriele Svelto [:gsvelto]]

Try run with a fix which should work: https://treeherder.mozilla.org/jobs?repo=try&revision=8319da0e2bf6abe4b3b3c3e791bc6b3e83e022b1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7d1c4c23e5a
Enforce the same alignment for the crash context across C++ and Rust r=afranchuk

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f7d1c4c23e5a