1903608 - Pressing enter on search bar settings icon does not open settings.

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 1903608 - Pressing enter on search bar settings icon does not open settings. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43caad016589
Pressing enter on search bar settings icon does not open settings. r=dao,search-reviewers,Standard8

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/43caad016589

Comment 4

[Moritz Beier [:mbeier]]

Attachment: Bug 1903608 - Pressing enter on search bar settings icon does not open settings.

Original Revision: https://phabricator.services.mozilla.com/D214287

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users using only keyboard navigation lose a (uncommon) way to open the settings.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: add searchbar, click the magnifying glass in the search bar, select the settings button using the arrow keys, press enter
• Risk associated with taking this patch: low
• Explanation of risk level: small change, only changes behavior of search bar when it is empty
• String changes made/needed: none
• Is Android affected?: no

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/469262b7c18e

Comment 7

[Peter Magyari (Desktop QA)]

Reproduced the issue on Beta 128.0b5 (20240619092300) and verified the fix on Beta 128.0b7 (20240624113619) and Nightly 129.0a1 (20240625213230) on MacOS 14, Windows 10 and Ubuntu 24.04.