Closed Bug 1903774 Opened 3 months ago Closed 3 months ago

Flex/Grid highlighter toggle button are rendered in Computed panel

Categories

(DevTools :: Inspector, defect)

defect

Tracking

(firefox-esr115 unaffected, firefox-esr128 unaffected, firefox127 unaffected, firefox128 unaffected, firefox129 fixed)

RESOLVED FIXED
129 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox127 --- unaffected
firefox128 --- unaffected
firefox129 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

In Bug 1901508, we made grid/flex highlighter render as buttons in the rule view.
It looks like we also render these buttons in the computed panel, they were just not visible before because they were empty span, onto which we weren't applying any style.
We shouldn't try to render those buttons in the computed panel in the first place

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1901508

Attachment #9408641 - Attachment description: Bug 1903774 - [devtools] Don't render flix/grid toggle button when associated class isn't pass to OutputParser. r=#devtools-reviewers. → Bug 1903774 - [devtools] Don't render flex/grid toggle button when associated class isn't pass to OutputParser. r=#devtools-reviewers.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/700f301b7f08
[devtools] Don't render flex/grid toggle button when associated class isn't pass to OutputParser. r=devtools-reviewers,ochameau.
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch

Set release status flags based on info from the regressing bug 1901508

QA Whiteboard: [qa-129b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: