1903780 - downloads.download throws if the folder name contains a dot and a space

Status: NEW

(WebExtensions :: Untriaged, defect)

Description

[eight04]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

1. Download and install the extension: https://github.com/eight04/webextension-test/archive/refs/heads/illegal-filename-2.zip
2. Click the extension button to trigger browserAction.
3. Inspect the background page and open the console.

Actual results:

Two errors are thrown:

Error: filename must not contain illegal characters

Expected results:

Two files are downloaded correctly with FF126 and Edge.

Reported by https://github.com/eight04/image-picka/issues/347#issuecomment-2173368486

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

I guess this is because we're intending to replace the space with _ in the file extension after bug 1891234. Neil, does that sound right? Can we refine the replacement so it doesn't affect the case reported here? (looks like it's a filename that contains . followed by somewhere, before the final .jpg)

Comment 3

[vcarciu]

I am not able to see any errors in consoles in FF 127 and 129, but also the files expected to be downloaded are not present.

Can you please attach a video or a screenshot with the errors?

Comment 4

[eight04]

Attachment: 2024-06-25 21-55-34.mkv

I started the browser via web-ext. Does it affect logging?

Comment 5

[Alex Cornestean]

Hello,

I reproduced the issue on the latest Nightly (129.0a1/20240625213230), Beta (128.0b7/20240624113619) and Release (127.0.2/20240624183754) under Windows 10 x64 and Ubuntu 22.04 LTS.

Clicking the extension button will throw two errors as mentioned in Comment 0 and the files are not downloaded. See the attached screenshots for more details.

Comment 6

[Alex Cornestean]

Attachment: 2024-06-26_09h37_57.png

Comment 8

[Donal Meehan [:dmeehan]]

:robwu do you plan on making a similar fix as in Bug 1898498?
:zombie could this be triaged for severity?

Comment 9

[Rob Wu [:robwu]]

I'm not planning to do the same fix as bug 1898498, because I don't think that we should disallow directories in the format blabla<dot><space>something.

I think that we need to use a different mechanism to verify whether an input is an acceptable directory name, because DownloadPaths.sanitize is now too strict.

• https://searchfox.org/mozilla-central/rev/b368ed8b48c0ea8ed2f1948e4776a6fbb5976dff/toolkit/components/extensions/parent/ext-downloads.js#704-709
• https://searchfox.org/mozilla-central/rev/b368ed8b48c0ea8ed2f1948e4776a6fbb5976dff/mobile/shared/components/extensions/ext-downloads.js#205-207