Split tracer actor in distinct class for each output type
Categories
(DevTools :: Debugger, enhancement)
Tracking
(firefox129 fixed)
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(3 files)
This will prevent having to check the log method for each frame,
but also help merge gecko-profile-collector with the actor,
and help use a single "resource" tracing for the console and debugger sidebar.
|
Assignee | |
Comment 1•3 months ago
|
||
This prevents having to check for the log method for each JavaScriptTracer class call.
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 2•3 months ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e6528c67df4 [devtools] Dispatch tracer calls in distinct JS classes. r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/58f1eca90f5b [devtools] Fold GeckoProfilerCollector into ProfilerTracingListener. r=devtools-reviewers,nchevobbe
|
|
Assignee | |
Updated•3 months ago
|
|
||
Comment 4•3 months ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 5•3 months ago
|
||
I forgot to push changes to address last review comments before requesting landing in lando.
|
|
Assignee | |
Updated•3 months ago
|
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/adf82b47a4f7 [devtools] Tweak eslint and add more code comments. r=devtools-reviewers,nchevobbe
|
||
Comment 7•3 months ago
|
||
| bugherder | ||
|
||
Comment 8•3 months ago
|
||
Perfherder has detected a devtools performance change from push 1ec92334e4004b81192210dc02ad54ea16c802a2.
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 4% | damp jstracer.ui-performance.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 1,948.56 -> 1,866.85 |
| 4% | damp jstracer.ui-performance.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 1,954.80 -> 1,877.57 |
| 4% | damp jstracer.ui-performance.DAMP | windows10-64-shippable-qr | e10s fission stylo webrender | 1,945.25 -> 1,870.69 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with ./mach try perf --alert 982
For more information on performance sheriffing please see our FAQ.
Description
•