1903819 - Re-enable Suggest reingestion (revert bug 1900928)

Status: RESOLVED FIXED

(Application Services :: Suggest, task)

Description

[Ben Dean-Kawamura [:bdk]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1900928 disabled Suggest re-ingestion because of performance issues. https://bugzilla.mozilla.org/show_bug.cgi?id=1900837 fixes those performance issues. Once 1900837 lands, we should revert 1900928.

Comment 1

[Ben Dean-Kawamura [:bdk]]

This landed on nightly 2024-06-17: https://hg.mozilla.org/releases/mozilla-release/rev/fae3703768c3 https://hg.mozilla.org/mozilla-central/rev/0288031e3158045df62e068b0acb3cd941233a66

Comment 2

[Ben Dean-Kawamura [:bdk]]

Attachment: Backout dd8cfe92844a9af9ff5b357ffb197d0d970f9f55 (Bug 1900928), r=lina

Comment 3

[Markus Stange [:mstange]]

(In reply to Ben Dean-Kawamura [:bdk] from comment #1)

This landed on nightly 2024-06-17: https://hg.mozilla.org/releases/mozilla-release/rev/fae3703768c3

This doesn't seem to be the right link - can you post the correct link?

Comment 4

[Ben Dean-Kawamura [:bdk]]

Sorry about that, the correct nightly rev is https://hg.mozilla.org/mozilla-central/rev/0288031e3158045df62e068b0acb3cd941233a66

Comment 5

[Markus Stange [:mstange]]

Thanks!

I'm somewhat surprised there was no automated comment for the relanding of the backout in bug 1900928.

I'm setting firefox127/8 to "affected" to reflect that suggest ingestion is still disabled on release and beta on Android.

Comment 6

[Ben Dean-Kawamura [:bdk]]

Comment on attachment 9408673 [details]
Backout dd8cfe92844a9af9ff5b357ffb197d0d970f9f55 (Bug 1900928), r=lina

Beta/Release Uplift Approval Request

• User impact if declined: Users will not see new suggestions when we update the remote settings collection.

Do not merge this one without the corresponding uplift from https://bugzilla.mozilla.org/show_bug.cgi?id=1900837, which fixes the performance issue that caused us to disable re-ingestion.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1900837
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is reverting a previous change and it's been tested on nightly for a while now.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9408673 [details]
Backout dd8cfe92844a9af9ff5b357ffb197d0d970f9f55 (Bug 1900928), r=lina

Approved for 128.0b9

Comment 8

[Donal Meehan [:dmeehan]]

Marking 128 as Fixed since this has landed in beta
https://hg.mozilla.org/releases/mozilla-beta/rev/34324e6f6bfc2e551db55dede2034a4e9e6f122b

Comment 9

[Adina Petridean QA [:apetridean]]

Attachment: suggest.JPEG

Comment 10

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest Nightly 129.0a1 from 30.06.2024 and 129.0b9 with Samsung Galaxy S23 Ultra (Android 14).