1903888 - Close duplicate tab confirmation message only appears if 2 or more tabs are closed

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Amy Lee [:amylee] UX]

The pop-up confirmation message appears for when a user uses the "Close all duplicate tabs" action for the first time in the tab overview menu. The message should appear the first time a user closes 1 or more duplicate tabs

Expected:

User clicks on "Close all duplicate tabs" in the Tab overflow menu

A one time pop-up confirmation appears the first time a user closes 1 or more duplicate tabs

Actual

Pop-up only appears when it closes 2 or more tabs.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I suspect we can fix this by moving this block above this condition.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1903888 - Warn on closing duplicate tabs even for 1 duplicate tab. r?#tabbrowser-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cad3f69422f
Warn on closing duplicate tabs even for 1 duplicate tab. r=tabbrowser-reviewers,dwalker

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1cad3f69422f

Comment 5

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 129.0a1 (2024-06-20) on Windows 10.
The issue is verified fixed with Firefox 130.0a1 (20240711215213) and Firefox 129.0b2 (20240710091735) on Windows 10, macOS 14 and Ubuntu 22.