Closed Bug 1903922 Opened 1 year ago Closed 1 year ago

disclosure-closed style has wrong expanders in RTL & vertical writing mode

Categories

(Core :: Layout: Generated Content, Lists, and Counters, defect)

Product:
Core
Component:
Layout: Generated Content, Lists, and Counters
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- verified
firefox130 --- verified

People

(Reporter: ntim, Assigned: jfkthame, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

testcase 1
122 bytes, text/html
Details
Bug 1903922 - Use upward-pointing disclosure triangle in vertical writing mode if directionality is RTL. r=#layout
48 bytes, text/x-phabricator-request
Details | Review
Bug 1903922 - Add an upward-pointing triangle glyph to -moz-bullet-font. r=#layout
48 bytes, text/x-phabricator-request
Details | Review
Bug 1903922 - Reftest for disclosure-triangles in various writing modes. r=#layout
48 bytes, text/x-phabricator-request
Details | Review

data:text/html,<ul style="writing-mode: vertical-lr; direction: rtl; list-style: disclosure-closed"><li>Hello

The arrow is pointing downwards instead of upwards.

Thanks for the bug report! I can reproduce.

Not a regression, or not a recent one at least; we render the testcase exactly the same at least as far back as Nightly 2019-01-01.

Severity: -- → S3
Component: CSS Parsing and Computation → Layout: Generated Content, Lists, and Counters
Attached file testcase 1 —

Here's the testcase as an attachment, for convenience/clickability.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d3074a8077b Use upward-pointing disclosure triangle in vertical writing mode if directionality is RTL. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/147da497b735 Add an upward-pointing triangle glyph to -moz-bullet-font. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/54e586b52673 Reftest for disclosure-triangles in various writing modes. r=layout-reviewers,emilio

Backed out for causing bc failures on browser_openPreferences.js.

[task 2024-06-21T23:30:19.847Z] 23:30:19     INFO - TEST-START | browser/components/aboutlogins/tests/browser/browser_openPreferences.js
[task 2024-06-21T23:30:24.440Z] 23:30:24     INFO - TEST-INFO | started process screentopng
[task 2024-06-21T23:30:24.984Z] 23:30:24     INFO - TEST-INFO | screentopng: exit 0
[task 2024-06-21T23:30:24.991Z] 23:30:24     INFO - Buffered messages logged at 23:30:19
[task 2024-06-21T23:30:24.992Z] 23:30:24     INFO - Entering setup bound setup_head
[task 2024-06-21T23:30:24.992Z] 23:30:24     INFO - Leaving setup bound setup_head
[task 2024-06-21T23:30:24.993Z] 23:30:24     INFO - Entering setup bound 
[task 2024-06-21T23:30:24.994Z] 23:30:24     INFO - Buffered messages logged at 23:30:20
[task 2024-06-21T23:30:24.994Z] 23:30:24     INFO - Leaving setup bound 
[task 2024-06-21T23:30:24.995Z] 23:30:24     INFO - Entering test bound test_open_preferences
[task 2024-06-21T23:30:24.996Z] 23:30:24     INFO - Buffered messages logged at 23:30:21
[task 2024-06-21T23:30:24.996Z] 23:30:24     INFO - waiting for new tab to get opened
[task 2024-06-21T23:30:24.997Z] 23:30:24     INFO - Buffered messages logged at 23:30:23
[task 2024-06-21T23:30:24.998Z] 23:30:24     INFO - Console message: [JavaScript Error: "downloadable font: kern: Zero length subtable is found (font-family: "-moz-bullet-font" style:normal weight:400 stretch:100 src index:0) source: data:font/woff2;base64,d09GMgABAAAAAATIAA0AAAAACpwAAAR3AAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAGzYGYACEEhEICoYwhEkBNgIkAywTEgswAAQgBYUIB … C9CMIkSV0DkKYa455ASgKUnTBdThtzqARsSUBxIWJLJ8FCZYligaaIYu1ki7kGz1GEMxhH/YdfWQXPh3DQCCwmCuTDHEFJe4xeMZPSSemu1ezCg9ZjALaCT3nDL2ngMA"]
[task 2024-06-21T23:30:24.999Z] 23:30:24     INFO - Console message: [JavaScript Error: "downloadable font: Table discarded (font-family: "-moz-bullet-font" style:normal weight:400 stretch:100 src index:0) source: data:font/woff2;base64,d09GMgABAAAAAATIAA0AAAAACpwAAAR3AAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAGzYGYACEEhEICoYwhEkBNgIkAywTEgswAAQgBYUIB … C9CMIkSV0DkKYa455ASgKUnTBdThtzqARsSUBxIWJLJ8FCZYligaaIYu1ki7kGz1GEMxhH/YdfWQXPh3DQCCwmCuTDHEFJe4xeMZPSSemu1ezCg9ZjALaCT3nDL2ngMA"]
[task 2024-06-21T23:30:25.000Z] 23:30:24     INFO - Buffered messages finished
[task 2024-06-21T23:30:25.000Z] 23:30:24     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | [JavaScript Error: "downloadable font: kern: Zero length subtable is found (font-family: "-moz-bullet-font" style:normal weight:400 stretch:100 src index:0) source: data:font/woff2;base64,d09GMgABAAAAAATIAA0AAAAACpwAAAR3AAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAGzYGYACEEhEICoYwhEkBNgIkAywTEgswAAQgBYUIB … C9CMIkSV0DkKYa455ASgKUnTBdThtzqARsSUBxIWJLJ8FCZYligaaIYu1ki7kGz1GEMxhH/YdfWQXPh3DQCCwmCuTDHEFJe4xeMZPSSemu1ezCg9ZjALaCT3nDL2ngMA"] - false == true - 
[task 2024-06-21T23:30:25.001Z] 23:30:24     INFO - Stack trace:
[task 2024-06-21T23:30:25.002Z] 23:30:24     INFO - chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/head.js:onConsoleMessage:189
[task 2024-06-21T23:30:25.002Z] 23:30:24     INFO - resource://testing-common/SpecialPowersChild.sys.mjs:observe/<:106
[task 2024-06-21T23:30:25.003Z] 23:30:24     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-06-21T23:30:25.004Z] 23:30:24     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | [JavaScript Error: "downloadable font: Table discarded (font-family: "-moz-bullet-font" style:normal weight:400 stretch:100 src index:0) source: data:font/woff2;base64,d09GMgABAAAAAATIAA0AAAAACpwAAAR3AAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAGzYGYACEEhEICoYwhEkBNgIkAywTEgswAAQgBYUIB … C9CMIkSV0DkKYa455ASgKUnTBdThtzqARsSUBxIWJLJ8FCZYligaaIYu1ki7kGz1GEMxhH/YdfWQXPh3DQCCwmCuTDHEFJe4xeMZPSSemu1ezCg9ZjALaCT3nDL2ngMA"] - false == true - 
[task 2024-06-21T23:30:25.005Z] 23:30:24     INFO - Stack trace:
[task 2024-06-21T23:30:25.005Z] 23:30:24     INFO - chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/head.js:onConsoleMessage:189
[task 2024-06-21T23:30:25.005Z] 23:30:24     INFO - resource://testing-common/SpecialPowersChild.sys.mjs:observe/<:106
[task 2024-06-21T23:30:25.271Z] 23:30:25     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | Must have seen an onLocationChange notification for the privacy-logins hash - true == true - 
[task 2024-06-21T23:30:25.276Z] 23:30:25     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | New tab opened to about:preferences - true == true - 
[task 2024-06-21T23:30:25.588Z] 23:30:25     INFO - GECKO(1577) | Waiting for 2 events, got 2
[task 2024-06-21T23:30:25.593Z] 23:30:25     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | waiting for telemetry event count - 2 == 2 - 
[task 2024-06-21T23:30:25.600Z] 23:30:25     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | content must be in snapshot. Has [parent,content]. - true == true - 
[task 2024-06-21T23:30:25.603Z] 23:30:25     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | After filtering we must have the expected number of events. Filtered events: [["pwmgr","mgmt_menu_item_used","preferences",null,null]] - 1 == 1 - 
[task 2024-06-21T23:30:25.605Z] 23:30:25     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | category in event pwmgr#mgmt_menu_item_used#preferences must match. - "pwmgr" matches "pwmgr" - 
[task 2024-06-21T23:30:25.607Z] 23:30:25     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | method in event pwmgr#mgmt_menu_item_used#preferences must match. - "mgmt_menu_item_used" matches "mgmt_menu_item_used" - 
[task 2024-06-21T23:30:25.608Z] 23:30:25     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | object in event pwmgr#mgmt_menu_item_used#preferences must match. - "preferences" matches "preferences" - 
[task 2024-06-21T23:30:25.610Z] 23:30:25     INFO - Leaving test bound test_open_preferences
[task 2024-06-21T23:30:25.803Z] 23:30:25     INFO - Console message: SENTINEL
[task 2024-06-21T23:30:26.211Z] 23:30:26     INFO - GECKO(1577) | MEMORY STAT | vsize 120606698MB | residentFast 1129MB
[task 2024-06-21T23:30:26.215Z] 23:30:26     INFO - TEST-OK | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | took 6369ms
[task 2024-06-21T23:30:26.339Z] 23:30:26     INFO - checking window state
[task 2024-06-21T23:30:26.461Z] 23:30:26     INFO - TEST-START | browser/components/aboutlogins/tests/browser/browser_openPreferencesExternal.js
Flags: needinfo?(jfkthame)
Flags: needinfo?(jfkthame)

Please also be aware of these failures:

Flags: needinfo?(jfkthame)
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c82f3dea0d67 Use upward-pointing disclosure triangle in vertical writing mode if directionality is RTL. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/becd5afc45c0 Add an upward-pointing triangle glyph to -moz-bullet-font. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/dec0bbe3b578 Reftest for disclosure-triangles in various writing modes. r=layout-reviewers,emilio
Pushed by nfay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22921b44a1c1 Fix whitespace lint failure in layout/style/res/html.css r=lint-fix CLOSED TREE
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/381558d71cc5 Use upward-pointing disclosure triangle in vertical writing mode if directionality is RTL. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/7d5056c95c12 Add an upward-pointing triangle glyph to -moz-bullet-font. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/da661e151336 Reftest for disclosure-triangles in various writing modes. r=layout-reviewers,emilio

https://hg.mozilla.org/mozilla-central/rev/381558d71cc5
https://hg.mozilla.org/mozilla-central/rev/7d5056c95c12
https://hg.mozilla.org/mozilla-central/rev/da661e151336

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch

Reproducible on a 2024-06-20 Nightly build on Windows 10.
Verified as fixed on Firefox 129.0b2 and Firefox Nightly 130.0a1 on Windows 10, Ubuntu 22, macOS 14.

Status: RESOLVED → VERIFIED
status-firefox129: fixed → verified
status-firefox130: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: