1904004 - Add a OriginAttributes::IsPrivateBrowsing helper method

Status: RESOLVED FIXED

(Core :: Security: CAPS, task)

Comment 1

[Tom Schuster]

Attachment: Bug 1904004 - Add OriginAttributes::IsPrivateBrowsing. r?timhuang

Comment 2

[Tom Schuster]

Attachment: Bug 1904004 - Use OriginAttributes::IsPrivateBrowsing instead of open coding PBM checks. r?timhuang

Comment 3

[Emma Zühlcke [:emz]]

Have you considered adding a linter to prevent new code from directly inspecting the private browsing id?

Comment 4

[Jan Varga [:janv]]

Is this a preparation for something bigger ?

Comment 5

[Tom Schuster]

Have you considered adding a linter to prevent new code from directly inspecting the private browsing id?

No, I hadn't really. I think it would be neat to have, but there are some valid use cases like serialization.

Is this a preparation for something bigger ?

No. Just some cleanup to make something like bug 1903559 less likely to happen.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb41003664bc
Add OriginAttributes::IsPrivateBrowsing. r=timhuang
https://hg.mozilla.org/integration/autoland/rev/9e5df1816e1c
Use OriginAttributes::IsPrivateBrowsing instead of open coding PBM checks. r=timhuang,cookie-reviewers,anti-tracking-reviewers,profiler-reviewers,necko-reviewers,kershaw,dom-storage-reviewers,janv,canaltinova,dom-worker-reviewers,asuth

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fb41003664bc
https://hg.mozilla.org/mozilla-central/rev/9e5df1816e1c