Open Bug 1904024 Opened 5 months ago Updated 4 months ago

Evaluate to completely avoid creating a check file to verify the executable bits of a download

Categories

(Toolkit :: Downloads API, task, P3)

Product:
Toolkit
Component:
Downloads API
Type:
task

Tracking

()

People

(Reporter: mak, Unassigned)

References

(Blocks 2 open bugs)

Details

in Bug 1900521 :yannis found that we create a dummy file to check for executable bits at https://searchfox.org/mozilla-central/source/uriloader/exthandler/nsExternalHelperAppService.cpp#1401-1412
Though, on Unix (based on bug) checking executable-ness this way isn't the right thing to do, and on Windows we should instead rely on the file extension. According to https://bugzilla.mozilla.org/show_bug.cgi?id=1900521#c5 nsLocalFile::IsExecutable is doing additional checks apart from the isExecutable bit check, we may still want to do those.

No longer blocks: 1900521
Depends on: 1900521
You need to log in before you can comment on or make changes to this bug.