1904052 - [wpt-sync] Sync PR 46862 - Don't clamp fragmentation block-size if it actually fits.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46862 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46862
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Don't clamp fragmentation block-size if it actually fits.

The code that called SetIsBlockSizeForFragmentationClamped() incorrectly
assumed that we had (so far) decided not to move past the fragment, but
this wasn't checked. This would cause the block-size for fragmentation
to be clamped, setting an incorrect BlockSizeForFragmentation()
(LayoutResult), which in turn could result in false cache hits: a
fragment would appear to fit within the new and smaller fragmentatainer
block-size, although it didn't.

Bug: 348445899
Change-Id: Ia7b74ba4861c341d1236bafcf881d6745ce0c161
Reviewed-on: https://chromium-review.googlesource.com/5645005
WPT-Export-Revision: 28b1fd1020a3b9a448a4aecfe7bdc58c7461db27

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2852f87edb5d7528ff01d82032a4bc0c83b452e8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6df3f19c3706
[wpt PR 46862] - Don't clamp fragmentation block-size if it actually fits., a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6df3f19c3706