[wpt-sync] Sync PR 46864 - Change ChildNodePart comment nodes from "S"/"E" to "#" and "/"
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 46864 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/46864
Details from upstream follow.
Mason Freed <masonf@chromium.org> wrote:
Change ChildNodePart comment nodes from "S"/"E" to "#" and "/"
This better matches the declarative HTML syntax, which is:
\<div parseparts>{{#}} child nodes {{/}}\</div>
No real functional change, since typical usage doesn't examine the
content of these comments.Bug: 40271855
Change-Id: Id2a4da2ee22b34e04dca2e4adca7bcacb57e5207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640573
Auto-Submit: Mason Freed \<masonf@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1317945}
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 11 subtests
Status Summary
Firefox
OK : 2
FAIL: 21
Chrome
OK : 2
PASS: 15
FAIL: 6
Safari
OK : 2
FAIL: 21
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /dom/parts/basic-dom-part-declarative-brace-syntax-innerhtml.tentative.html [wpt.fyi]
- Declarative DOM Parts innerHTML <div><h1>content... (expect no parts):
FAIL(Chrome:PASS, Safari:FAIL) - Declarative DOM Parts innerHTML <div><h1 parseparts>content... (expect no parts):
FAIL(Chrome:PASS, Safari:FAIL) - Declarative DOM Parts innerHTML <div parseparts=""><h1>content... (expect no parts):
FAIL(Chrome:PASS, Safari:FAIL) - Declarative DOM Parts innerHTML <div parseparts=""><h1 parseparts>content... (expect no parts):
FAIL(Chrome:PASS, Safari:FAIL) - Declarative DOM Parts innerHTML <template><h1>content... (expect no parts):
FAIL(Chrome:PASS, Safari:FAIL) - Declarative DOM Parts innerHTML <template><h1 parseparts>content... (expect no parts):
FAIL(Chrome:PASS, Safari:FAIL) - Declarative DOM Parts innerHTML <template parseparts="" class="expect_success"><h1>content... (expect parts):
FAIL(Chrome:PASS, Safari:FAIL) - Declarative DOM Parts innerHTML <template parseparts="" class="expect_success"><h1 parseparts>content... (expect parts):
FAIL(Chrome:PASS, Safari:FAIL) - Basic NodePart parsing:
FAIL(Chrome:FAIL, Safari:FAIL) - Basic AttributePart parsing with multiple attributes:
FAIL(Chrome:FAIL, Safari:FAIL)
- Declarative DOM Parts innerHTML <div><h1>content... (expect no parts):
- /dom/parts/basic-dom-part-declarative-brace-syntax.tentative.html [wpt.fyi]
- Basic declarative DOM Parts (Main Document):
FAIL(Chrome:FAIL, Safari:FAIL) - Basic declarative DOM Parts (Template):
FAIL(Chrome:FAIL, Safari:FAIL) - Basic declarative DOM Parts (Clone):
FAIL(Chrome:PASS, Safari:FAIL) - Basic declarative DOM Parts (PartClone):
FAIL(Chrome:PASS, Safari:FAIL) - Post-parsing structure of child parts, and stickiness:
FAIL(Chrome:PASS, Safari:FAIL) - Parser only behavior - adding parseparts does nothing:
FAIL(Chrome:PASS, Safari:FAIL) - Just parts, no text before:
FAIL(Chrome:FAIL, Safari:FAIL) - Self closing elements can't use parseparts:
FAIL(Chrome:PASS, Safari:FAIL) - Second head element can't use parseparts:
FAIL(Chrome:PASS, Safari:FAIL) - Foreign content should support Parts:
FAIL(Chrome:FAIL, Safari:FAIL) - Not quite parts syntax - none should become parts, and nothing should crash:
FAIL(Chrome:PASS, Safari:FAIL)
- Basic declarative DOM Parts (Main Document):
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Description
•