1904110 - Add space tokens to moz-page-nav-button.css

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug.
   • You'll need to replace gap: 12px with gap: var(--space-medium)
   • You can find the space tokens in tokens-shared.css
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your change with mach storybook and the devtools inspector. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 1

[Louis Mascari]

Hello, I'm a new a contributor and will be working on this bug, thanks.

Comment 2

[Louis Mascari]

Attachment: WIP: Bug 1904110 - Add space tokens to moz-page-nav-button.css

Comment 3

[Louis Mascari]

Attachment: Bug 1904110 - Add space tokens to moz-page-nav-button.css. r?tgiles!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a561ff5fde2c
Add space tokens to moz-page-nav-button.css. r=tgiles,reusable-components-reviewers

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a561ff5fde2c