1904222 - Crash in [@ mozilla::layers::CanvasChild::EnsureRecorder]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[BugBot [:suhaib / :marco]]

Crash report: https://crash-stats.mozilla.org/report/index/ee345370-436b-49b4-aa17-48df50240602

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(mRecorder->GetTextureType() == aTextureType) (We only support one remote TextureType currently.)

Top 10 frames of crashing thread:

0  xul.dll  mozilla::layers::CanvasChild::EnsureRecorder  gfx/layers/ipc/CanvasChild.cpp:335
1  xul.dll  mozilla::layers::RecordedTextureData::RecordedTextureData  gfx/layers/client/TextureRecorded.cpp:29
1  xul.dll  mozilla::layers::TextureData::Create  gfx/layers/client/TextureClient.cpp:378
1  xul.dll  mozilla::layers::TextureClient::CreateForDrawing  gfx/layers/client/TextureClient.cpp:1378
2  xul.dll  mozilla::layers::TextureClient::CreateForDrawing  gfx/layers/client/TextureClient.cpp:1354
2  xul.dll  mozilla::layers::CreateTexture  gfx/layers/PersistentBufferProvider.cpp:113
3  xul.dll  mozilla::layers::PersistentBufferProviderAccelerated::Create  gfx/layers/PersistentBufferProvider.cpp:149
4  xul.dll  mozilla::dom::CanvasRenderingContext2D::TryAcceleratedTarget  dom/canvas/CanvasRenderingContext2D.cpp:1737
5  xul.dll  mozilla::dom::CanvasRenderingContext2D::EnsureTarget  dom/canvas/CanvasRenderingContext2D.cpp:1590
6  xul.dll  mozilla::dom::CanvasRenderingContext2D::DrawImage  dom/canvas/CanvasRenderingContext2D.cpp:5491

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2024-05-15
• Process type: Content
• Is startup crash: No
• Has user comments: No
• Is null crash: No

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

This seems severe, but not to affect many folks. Tentatively triaging as an S3.

Lee, can you comment on this? It seems interesting that this is happening inside a CanvasRenderingContext2D::DrawImage call.

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1904222 - Use non-remote rendering if texture types don't match. r?aosmond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f307df5d65a
Use non-remote rendering if texture types don't match. r=aosmond

Comment 4

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/2f307df5d65a