1904228 - MLB box scores hard to read

Status: VERIFIED FIXED

(Firefox :: Untriaged, defect)

Description

[Blake]

Attachment: MLB.png

Steps to reproduce:

From MLB.com, hover over a game a load a Wrap or Gameday

Example: https://www.mlb.com/gameday/angels-vs-dodgers/2024/06/22/746132/live

Actual results:

Dark text on a dark background are hard to read.

Expected results:

Should be white text on a dark background

Comment 1

[Blake]

Mozregression point to bug 1886441

app_name: firefox
build_date: 2024-06-01 08:54:26.107000
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/JpRIiDKQSxWvrIFlVGBugQ/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: e07b07b08958af7d59d7fbc50699d24cd6755c25
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ce2f8f439778664ec91353f922b3cb9d8144e713&tochange=e07b07b08958af7d59d7fbc50699d24cd6755c25
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: JpRIiDKQSxWvrIFlVGBugQ

Comment 2

[Blake]

More specifically, Bug 1886441: Part 7 - Fast-reject with ancestor hashes for @scope.

Differential Revision: https://phabricator.services.mozilla.com/D208028

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:dshin, since you are the author of the regressor, bug 1886441, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[David Shin[:dshin]]

Attachment: Minimum Reproducible Case

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1886441

Comment 6

[David Shin[:dshin]]

Attachment: Bug 1904228: Don't consider :scope selectors to be featureless outside of `@scope`. r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b2aa4fe8eac
Don't consider :scope selectors to be featureless outside of `@scope`. r=emilio

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46882 for changes under testing/web-platform/tests

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1b2aa4fe8eac

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dshin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[David Shin[:dshin]]

Comment on attachment 9409124 [details]
Bug 1904228: Don't consider :scope selectors to be featureless outside of @scope. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: Unintended styling on sites using :scope out of @scope
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Ensure that browser is in dark theme

2. Load https://www.mlb.com/gameday/angels-vs-dodgers/2024/06/22/746132/live as in comment 0
3. Ensure score text has high contrast from background (i.e. background is dark, text is white)

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change, only affects use of :scope selectors, half of which is hidden behind @scope pref (layout.css.at-scope.enabled), which then is well-covered by WPT
• String changes made/needed: N/A
• Is Android affected?: Yes

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9409124 [details]
Bug 1904228: Don't consider :scope selectors to be featureless outside of @scope. r=emilio

Approved for 128.0b8

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2be014b304c8

Comment 16

[Virgil Sangerean]

Issue is verified fixed in 129.0a1 Firefox from the 25th of June.
Issue is still present in 128.b7. Waiting for 128.b8 Firefox for verification.

Comment 17

[Virgil Sangerean]

Issue is verified fixed in 128.b8 Firefox.