1904278 - Investigate whether it's intentional or a bug that `PopupBlocker::GetEventPopupControlState` does not handle `auxclick` if it's caused by a middle button

Status: NEW

(Core :: DOM: Core & HTML, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

See here and here, auxclick event is handled in the else if case against aEvent->AsPointerEvent()->mButton == MouseButton::ePrimary || aEvent->AsPointerEvent()->mButton == MouseButton::eMiddle. This looks really odd. Even if it's intentional, it should be explained with an inline comment.

Edgar, could you take a look when you have much time?

Comment 1

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

We should mostly get rid of PopupBlocker::GetEventPopupControlState and rely on user activation state.

Comment 2

[Edgar Chen [:edgar]]

Yes, I think that won't be a problem after bug 1896672 which fallback to check user activation when popup blocker state is openBlocked (and we could get rid of popup blocker state then).