1904310 - Disable system add-on updates

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Originally filed on the pdf.js project: https://github.com/mozilla/pdf.js/pull/18316

Right now we only modify the remote URL to not cause external network access. But that actually causes log entries like:

System addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL.

Instead we should disable the feature by setting the preference extensions.systemAddon.update.enabled to false, and at the same time remove extensions.systemAddon.update.url.

See our documentation in where it needs to be changed. Sounds like a good candidate for a mentored bug.

Comment 1

[cauasene00]

Attachment: Bug 1904310 - Disabled system add-on updates and remove the update url. r=whimboo

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ce4c0ffa437
Disabled system add-on updates and remove the update url. r=webdriver-reviewers,jdescottes

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3ce4c0ffa437

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Thank you a lot cauasene00 for providing this patch! Great to see that the whole process of getting the source, building Firefox, creating the patch and requesting review went through that smoothly for you. If you want to contribute more in our area please check our other bugs or ask as and we can help with a bug selection. Feel free to join us in the #webdriver channel on Matrix.

Comment 5

[cauasene00]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #4)

Thank you a lot cauasene00 for providing this patch! Great to see that the whole process of getting the source, building Firefox, creating the patch and requesting review went through that smoothly for you. If you want to contribute more in our area please check our other bugs or ask as and we can help with a bug selection. Feel free to join us in the #webdriver channel on Matrix.

You're welcome! I'm glad the patch was helpful. I'd love to contribute more and would appreciate help with bug selection. I'll join the matrix channel. Thanks!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

(In reply to cauasene00 from comment #5)

You're welcome! I'm glad the patch was helpful. I'd love to contribute more and would appreciate help with bug selection. I'll join the matrix channel. Thanks!

I tried to reach out on Matrix but you may not be around. So lets follow-up here so that we have a reference. Would you be interested to have a look at bug 1838158 as next? Thanks!

Comment 7

[cauasene00]

Sure, I'd be happy to look into bug 1838158.(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #6)

(In reply to cauasene00 from comment #5)

You're welcome! I'm glad the patch was helpful. I'd love to contribute more and would appreciate help with bug selection. I'll join the matrix channel. Thanks!

I tried to reach out on Matrix but you may not be around. So lets follow-up here so that we have a reference. Would you be interested to have a look at bug 1838158 as next? Thanks!

Sure, I'd be happy to look into bug 1838158. Sorry, I totally forgot about Matrix lately i’ll try to be more active there from now on.