1904328 - Share string buffer when passing JS strings between zones

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jan de Mooij [:jandem]]

Non-atom strings belong to a single zone and are copied when passed to other zones. For strings with a shared StringBuffer, we can instead allocate a new JS string that shares the underlying buffer.

Strings with string buffers aren't that common yet, but this will change as we start using them more.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1904328 part 1 - Remove chars argument from new_/newValidLength functions. r?sfink!

This is a bit simpler for the callers.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1904328 part 2 - Optimize CopyStringPure to share StringBuffer if possible. r?sfink!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4a5e8d94644
part 1 - Remove chars argument from new_/newValidLength functions. r=sfink
https://hg.mozilla.org/integration/autoland/rev/2a9c086e4781
part 2 - Optimize CopyStringPure to share StringBuffer if possible. r=sfink

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c4a5e8d94644
https://hg.mozilla.org/mozilla-central/rev/2a9c086e4781