1904379 - network.continueRequest does not support multiple values for the same header name

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Julian Descottes [:jdescottes]]

The BiDi spec for continueRequest does not restrict headers to a single value per name.
It should be possible to set multiple values for a single header name.

Technically setting nameA:value1 + nameA:value2 is equivalent to nameA:value1, value2, so we should support that.
At the moment Firefox will only set nameA:value2

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1904379 - [bidi] Support setting multiple values for single header name in continueRequest

Comment 2

[Julian Descottes [:jdescottes]]

I spotted this issue while looking at puppeteer tests for provideResponse. I used merge=false when calling the APIs to setRequestHeaders for network.continueRequest, but in theory we should support multiple header values.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1904379 - [wdspec] Add test for multiple header values with bidi network.continueRequest

Depends on D214730

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42e5bcd525ef
[bidi] Support setting multiple values for single header name in continueRequest r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/192ebf2a6aff
[wdspec] Add test for multiple header values with bidi network.continueRequest r=webdriver-reviewers,whimboo

Comment 5

[Cristian Tuns]

Backed out for causing failures in cookies.py

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /webdriver/tests/bidi/network/continue_request/cookies.py | test_override_modified_header_cookies - AssertionError

Comment 6

[Julian Descottes [:jdescottes]]

For scenarios where we have both a cookie header and cookies parameters we actually should NOT merge.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7726ece8e7f
[bidi] Support setting multiple values for single header name in continueRequest r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/d08a4c993db0
[wdspec] Add test for multiple header values with bidi network.continueRequest r=webdriver-reviewers,whimboo

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46912 for changes under testing/web-platform/tests

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a7726ece8e7f
https://hg.mozilla.org/mozilla-central/rev/d08a4c993db0

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot