1904395 - clang-18 build failure due to incompatible function types

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[John Schanck [:jschanck]]

When building with clang-18, I get

../../../pr/tests/testfile.c:576:31: error: incompatible function pointer types passing 'PRInt32 (void *)' (aka 'int (void *)') to parameter of type 'void (*)(void *)' [-Wincompatible-function-pointer-types]
  576 |                               DirTest, &thrarg,
      |                               ^~~~~~~
../../../pr/tests/testfile.c:93:36: note: passing argument to parameter 'start' here
   93 |                             void (*start)(void *arg),
      |                                    ^

I took a crack at fixing it, but the test itself is in pretty rough shape---I'm not sure it's useful, or even correct, as is.

Comment 1

[Mike Hommey [:glandium]]

Same with GCC 14.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:KaiE, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Kai Engert (:KaiE:)]

Attachment: Bug 1904395 - Fix incompatible native thread start type. r=jschanck

Comment 4

[Kai Engert (:KaiE:)]

What do you think about my patch?
It tries to fix the pointer types.

Comment 5

[Kai Engert (:KaiE:)]

Attachment: Bug 1904395 - Fix incompatible native thread start type. r=jschanck

Comment 6

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nspr/rev/e178d3d9b47b2479f22f208d6225eda81918dae1