Closed Bug 1904410 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 46883 - webnn: Immediately copy constant data

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox129 fixed)

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46883 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46883
Details from upstream follow.

Austin Sullivan <asully@chromium.org> wrote:

webnn: Immediately copy constant data

Currently, the data of ArrayBufferViews passed to the constant() method
is copied during the build() method. This does not match the spec:
https://www.w3.org/TR/webnn/#dom-mlgraphbuilder-constant

Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Bug: 348598508
Change-Id: Ief7a686324375fb2027df8a30d2c97943149bbe6
Reviewed-on: https://chromium-review.googlesource.com/5649032
WPT-Export-Revision: 055643f3853a1c9de114cbee0b9698710e47ee27

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 2
PASS: 2
FAIL: 6

Chrome

OK : 2
PASS: 4
FAIL: 4

Safari

OK : 2
PASS: 2
FAIL: 6

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webnn/validation_tests/constant-changed-buffer.https.any.worker.html [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • Constant data is unaffected by detaching the buffer: FAIL (Chrome: FAIL, Safari: FAIL)
    • Constant data is unaffected by changes to the buffer contents: FAIL (Chrome: FAIL, Safari: FAIL)
  • /webnn/validation_tests/constant-changed-buffer.https.any.html [wpt.fyi]
    • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
    • Constant data is unaffected by detaching the buffer: FAIL (Chrome: FAIL, Safari: FAIL)
    • Constant data is unaffected by changes to the buffer contents: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/753c8f5a7851 [wpt PR 46883] - webnn: Immediately copy constant data, a=testonly

https://hg.mozilla.org/mozilla-central/rev/753c8f5a7851

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.