1904442 - Consider making GlobalTeardownObserver::mOwnerWindow a bool

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

Seems it could be a bool + static_cast instead of a whole pointer, and it might save some memory because it's used in not-totally-uncommon objects like MediaQueryList / AbortSignal / Animation... I guess most other objects using this are not that common.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1904442 - Rename GlobalTeardownObserver::GetOwner to GetOwnerWindow. r=smaug

Also HasOrHasHadOwner to HasOrHasHadOwnerWindow.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1904442 - Remove GlobalTearDownObserver::mOwnerWindow. r=smaug

We can just static_cast.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85e6e9cc4489
Rename GlobalTeardownObserver::GetOwner to GetOwnerWindow. r=smaug,media-playback-reviewers,dom-storage-reviewers,aosmond,padenot,asuth
https://hg.mozilla.org/integration/autoland/rev/df7327d207f1
Remove GlobalTearDownObserver::mOwnerWindow. r=smaug
https://hg.mozilla.org/integration/autoland/rev/c0605ff88f9d
apply code formatting via Lando

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/85e6e9cc4489
https://hg.mozilla.org/mozilla-central/rev/df7327d207f1
https://hg.mozilla.org/mozilla-central/rev/c0605ff88f9d