Closed
Bug 1904445
Opened 2 years ago
Closed 2 years ago
[Menu Redesign] Launch the new menu redesign from browser without relying on the toolbar redesign
Categories
(Firefox for Android :: Toolbar, task, P1)
Tracking
()
RESOLVED
FIXED
131 Branch
| Tracking | Status | |
|---|---|---|
| firefox131 | --- | fixed |
People
(Reporter: sanchaai, Assigned: gl)
References
Details
Attachments
(4 external files)
The task here is to ensure we can launch new menu redesign from the browser as long as the menu redesign secret setting is turned on. This means we want to be able to launch the new menu redesign from the browser using the old toolbar as well as the new toolbar whenever the menu redesign secret setting is turned on.
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P1
| Assignee | ||
Updated•2 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•2 years ago
|
||
| Assignee | ||
Comment 3•2 years ago
|
||
Originally, the sessionId is only provided when there's a custom tab. Otherwise, it is always null if it is a normal browser session.
Instead of calling this sessionId where it might imply that this could be a normal browser session, let's rename this to customTabId to make it very clear that this is either a custom tab id or null if it is a normal browser session.
| Assignee | ||
Comment 4•2 years ago
|
||
| Assignee | ||
Comment 5•2 years ago
|
||
Updated•2 years ago
|
Attachment #9419152 -
Attachment description: WIP: Bug 1904445 - Part 1: Refactor reader mode action and feature into its own init function in BrowserFragment → Bug 1904445 - Part 1: Refactor reader mode action and feature into its own init function in BrowserFragment
Updated•2 years ago
|
Attachment #9419153 -
Attachment description: WIP: Bug 1904445 - Part 2: Rename sessionId to customTabId in MenuPresenter and ToolbarIntegration implementations → Bug 1904445 - Part 2: Rename sessionId to customTabId in MenuPresenter and ToolbarIntegration implementations
Updated•2 years ago
|
Attachment #9419154 -
Attachment description: WIP: Bug 1904445 - Part 3: Add Menu browser action in the browser and custom tab toolbar integration → Bug 1904445 - Part 3: Add Menu browser action in the browser and custom tab toolbar integration
Updated•2 years ago
|
Attachment #9419155 -
Attachment description: WIP: Bug 1904445 - Part 4: Add telemetry for clicking on the browser menu action → Bug 1904445 - Part 4: Add telemetry for clicking on the browser menu action
Updated•2 years ago
|
| Assignee | ||
Updated•2 years ago
|
Keywords: leave-open
Updated•2 years ago
|
Attachment #9419153 -
Attachment description: Bug 1904445 - Part 2: Rename sessionId to customTabId in MenuPresenter and ToolbarIntegration implementations → Bug 1904445 - Part 2: Rename sessionId to customTabId in MenuPresenter, BrowserToolbarCFRPresenter and ToolbarIntegration implementations
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7699969c86c
Part 1: Refactor reader mode action and feature into its own init function in BrowserFragment r=android-reviewers,petru
https://hg.mozilla.org/integration/autoland/rev/1af5b1f3335d
Part 2: Rename sessionId to customTabId in MenuPresenter, BrowserToolbarCFRPresenter and ToolbarIntegration implementations r=android-reviewers,petru
https://hg.mozilla.org/integration/autoland/rev/cf5c914fd778
Part 3: Add Menu browser action in the browser and custom tab toolbar integration r=android-reviewers,petru
Comment 7•2 years ago
|
||
| bugherder | ||
Updated•2 years ago
|
Attachment #9419155 -
Attachment description: Bug 1904445 - Part 4: Add telemetry for clicking on the browser menu action → Bug 1904445 - Part 4: Record telemetry for opening the home and browser menu from the toolbar
| Assignee | ||
Updated•2 years ago
|
Keywords: leave-open
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6478c5d93c1
Part 4: Record telemetry for opening the home and browser menu from the toolbar r=android-reviewers,petru
Comment 9•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox131:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•