1904445 - [Menu Redesign] Launch the new menu redesign from browser without relying on the toolbar redesign

Status: RESOLVED FIXED

(Fenix :: Toolbar, task, P1)

Description

[Sanchaai [:sanchaai]]

The task here is to ensure we can launch new menu redesign from the browser as long as the menu redesign secret setting is turned on. This means we want to be able to launch the new menu redesign from the browser using the old toolbar as well as the new toolbar whenever the menu redesign secret setting is turned on.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1904445 - Part 1: Refactor reader mode action and feature into its own init function in BrowserFragment

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1904445 - Part 2: Rename sessionId to customTabId in MenuPresenter, BrowserToolbarCFRPresenter and ToolbarIntegration implementations

Originally, the sessionId is only provided when there's a custom tab. Otherwise, it is always null if it is a normal browser session.
Instead of calling this sessionId where it might imply that this could be a normal browser session, let's rename this to customTabId to make it very clear that this is either a custom tab id or null if it is a normal browser session.

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1904445 - Part 3: Add Menu browser action in the browser and custom tab toolbar integration

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1904445 - Part 4: Record telemetry for opening the home and browser menu from the toolbar

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7699969c86c
Part 1: Refactor reader mode action and feature into its own init function in BrowserFragment r=android-reviewers,petru
https://hg.mozilla.org/integration/autoland/rev/1af5b1f3335d
Part 2: Rename sessionId to customTabId in MenuPresenter, BrowserToolbarCFRPresenter and ToolbarIntegration implementations r=android-reviewers,petru
https://hg.mozilla.org/integration/autoland/rev/cf5c914fd778
Part 3: Add Menu browser action in the browser and custom tab toolbar integration r=android-reviewers,petru

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f7699969c86c
https://hg.mozilla.org/mozilla-central/rev/1af5b1f3335d
https://hg.mozilla.org/mozilla-central/rev/cf5c914fd778

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6478c5d93c1
Part 4: Record telemetry for opening the home and browser menu from the toolbar r=android-reviewers,petru

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c6478c5d93c1