1904478 - Perma [Tier 2] browser/components/preferences/tests/browser_experimental_features_resetall.js | single tracking bug

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=463886118&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NSQmucfdQ5OOFQ_2JRZnag/runs/0/artifacts/public/logs/live_backing.log

---

TEST-PASS | browser/components/preferences/tests/browser_experimental_features_resetall.js | initial state D - 
[task 2024-06-25T02:11:24.213Z] 02:11:24     INFO - Buffered messages finished
[task 2024-06-25T02:11:24.215Z] 02:11:24     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_experimental_features_resetall.js | Interactive elements must be labeled: id: test-featureC, tagName: checkbox, className: featureGateCheckbox - 
[task 2024-06-25T02:11:24.215Z] 02:11:24     INFO - Stack trace:
[task 2024-06-25T02:11:24.215Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:test_ok:1597
[task 2024-06-25T02:11:24.216Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:752
[task 2024-06-25T02:11:24.216Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:966
[task 2024-06-25T02:11:24.216Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:1173
[task 2024-06-25T02:11:24.216Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:1137
[task 2024-06-25T02:11:24.217Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:1254
[task 2024-06-25T02:11:24.217Z] 02:11:24     INFO - chrome://mochitests/content/browser/browser/components/preferences/tests/browser_experimental_features_resetall.js:testResetAll:77
[task 2024-06-25T02:11:24.217Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-06-25T02:11:24.218Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-06-25T02:11:24.218Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-06-25T02:11:24.218Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-06-25T02:11:24.218Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-06-25T02:11:24.219Z] 02:11:24     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-06-25T02:11:24.221Z] 02:11:24     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_experimental_features_resetall.js | Interactive elements must be labeled: id: test-featureD, tagName: checkbox, className: featureGateCheckbox - 
[task 2024-06-25T02:11:24.221Z] 02:11:24     INFO - Stack trace:
[task 2024-06-25T02:11:24.221Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:test_ok:1597
[task 2024-06-25T02:11:24.221Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:752
[task 2024-06-25T02:11:24.222Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertLabelled:966
[task 2024-06-25T02:11:24.222Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:1173
[task 2024-06-25T02:11:24.222Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:1137
[task 2024-06-25T02:11:24.222Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleEvent:1254
[task 2024-06-25T02:11:24.223Z] 02:11:24     INFO - chrome://mochitests/content/browser/browser/components/preferences/tests/browser_experimental_features_resetall.js:testResetAll:78
[task 2024-06-25T02:11:24.223Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-06-25T02:11:24.223Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-06-25T02:11:24.223Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-06-25T02:11:24.223Z] 02:11:24     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-06-25T02:11:24.223Z] 02:11:24     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-06-25T02:11:24.224Z] 02:11:24     INFO - TEST-PASS | browser/components/preferences/tests/browser_experimental_features_resetall.js | modified state A - 

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:Gijs, since you are the author of the regressor, bug 1903820, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1904478 - clean up leftover reference to now non-existing fluent string, r?#settings-reviewers

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1903820

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/829b761759c1
clean up leftover reference to now non-existing fluent string, r=settings-reviewers

Comment 5

[:Gijs (he/him)]

So this test framework caught that the fluent string didn't exist anymore, because it expected a label and none existed.

What I don't really understand is why this didn't cause more errors (outside of this test framework, whenever we "normally" ran the test in question), after our recent changes where (I thought) non-existing strings should cause test failures... In fact, even after the patch I submitted there are still non-existing strings there... cf. https://searchfox.org/mozilla-central/rev/9fcc11127fbfbdc88cbf37489dac90542e141c77/browser/components/preferences/tests/head.js#205 .

Comment 6

[:Gijs (he/him)]

(I checked locally and I don't see l10n errors for these strings in the console, even if I delay finishing the test to make very sure there's been a fluent pass in the doc)

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/829b761759c1

Comment 8

[Intermittent Failures Robot]

13 failures in 4116 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 11
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-shippable-qr: 4
  • opt: 4
• linux1804-64-qr: 9
  • opt: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1904478&startday=2024-06-24&endday=2024-06-30&tree=all

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1903820

Comment 10

[Eemeli Aro [:eemeli]]

Looking into this, I realised that I'd missed out that we ignore errors when applying updates to DOM localization, and so revived the second part of the previously prepared fix for bug 1889417 that'll ensure that they're at least logged in tests.

Comment 11

[Intermittent Failures Robot]

2 failures in 4124 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform and build breakdown:

• linux1804-64-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1904478&startday=2024-07-22&endday=2024-07-28&tree=all