1904528 - Split [@ RtlpFreeHeapInternal | RtlFreeHeap | APP_DATA::FreeCachedMem] into different signatures

Status: RESOLVED FIXED

(Socorro :: Signature, task, P3)

Description

[Yannis Juglaret [:yannis]]

See bug 1900964 and the related bugs listed below. The signature [@ RtlpFreeHeapInternal | RtlFreeHeap | APP_DATA::FreeCachedMem] currently groups together multiple issues which are not easy to separate. Ideally we would keep two more levels in the signature to have e.g.:

• RtlpFreeHeapInternal | RtlFreeHeap | APP_DATA::FreeCachedMem | SysFreeString | pxcdrvl.dll for bug 1900796 (example);
• RtlpFreeHeapInternal | RtlFreeHeap | APP_DATA::FreeCachedMem | SysFreeString | database.dll for bug 1901230 (example);
• RtlpFreeHeapInternal | RtlFreeHeap | APP_DATA::FreeCachedMem | VariantClear | qyui.dll for bug 1902010 (example).

An example where two more levels is not exactly enough is:

• RtlpFreeHeapInternal | RtlFreeHeap | APP_DATA::FreeCachedMem | SysFreeString | VariantClearWorker | VariantClear | TAsyncNotifyCallbackHandler::ExtractStatusFromXmlMessage for bug 1675760 (example).

Comment 1

[Andrew McCreight [:mccr8]]

It looks like what you want is to add VariantClear, SysFreeString and (for the last example) VariantClearWorker to the prefix list. It is pretty easy to put together a pull request via the GitHub UI by clicking on the pencil icon to edit the file. There's some documentation here. Signature changes are mostly on a self-serve basis, but it should only take a few minutes.

Comment 2

[Yannis Juglaret [:yannis]]

That looks like what I need here indeed, and APP_DATA::FreeCachedMem as well. Thanks for the info!

Comment 3

[Andrew McCreight [:mccr8]]

(In reply to Yannis Juglaret [:yannis] from comment #2)

and APP_DATA::FreeCachedMem as well.

Ah right. I managed to overlook the most important one somehow.

Comment 4

[Daniel Thorn [:relud]]

This was deployed in bug 1906174 just now.