1904557 - Unify and improve cookie warning messages

Status: RESOLVED FIXED

(Core :: Networking: Cookies, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

The current cookie parsing implementation generates several error and warning messages in case the cookies are invalid or not fully spec compliant. These messages are often confusing for the developer because they are not grouped and do not follow a particular order or priority.

I would suggest the following changes:

1. Move the cookie parsing logic to a separate class: CookieParser.
2. This class does not report warning/error messages during the parsing but, instead, it collects them
3. Only at the end of the parsing the warning/error messages are reported following this logic:

• if there is a cookie rejection, only the rejection message is printed
• if the cookie is not rejected, all the warning messages are reported
• the warning messages are grouped under a Cookie warnings console group.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1904557 - part 1 - Improve cookie logging - Move cookie parser methods into a CookieParser class, r?timhuang

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1904557 - part 2 - Improve cookie logging - Move the warning/reject logic in CookieParser, r?timhuang

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1904557 - part 3 - Improve cookie logging - Groupping the console warnings, r?timhuang

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3b18bb35281
part 1 - Improve cookie logging - Move cookie parser methods into a CookieParser class, r=timhuang,cookie-reviewers,edgul
https://hg.mozilla.org/integration/autoland/rev/f8dfc2e9673f
part 2 - Improve cookie logging - Move the warning/reject logic in CookieParser, r=timhuang,cookie-reviewers,edgul
https://hg.mozilla.org/integration/autoland/rev/2ce77cdcbb97
part 3 - Improve cookie logging - Groupping the console warnings, r=timhuang,devtools-reviewers,cookie-reviewers,ochameau

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d3b18bb35281
https://hg.mozilla.org/mozilla-central/rev/f8dfc2e9673f
https://hg.mozilla.org/mozilla-central/rev/2ce77cdcbb97