Closed Bug 1904615 Opened 5 months ago Closed 5 months ago

[pipewire] bad handling of pw_buffer with only cursor metadata

Categories

(Core :: WebRTC: Audio/Video, defect)

Firefox 127
Unspecified
Linux
defect

Tracking

()

RESOLVED DUPLICATE of bug 1896575
Tracking Status
firefox-esr115 --- unaffected
firefox127 --- wontfix
firefox128 --- fixed
firefox129 --- fixed

People

(Reporter: martin, Unassigned)

References

Details

Attachments

(1 file)

This is a follow up from KDE bug: https://bugs.kde.org/show_bug.cgi?id=487300
When screencasting with firefox, and there is only cursor movement (window in question is minimized) , firefox displays garbled images.
kwin 6.1.0, wayland, radeonsi driver.
Do note that this might no longer be easily reproducible once https://bugs.kde.org/show_bug.cgi?id=487294 is fixed.

steps:
1 minimize a window
2 share only window to firefox
3 move cursor over original place of window

comment from kwin developer:
"I believe it's either a webrtc or a firefox bug. It looks like it doesn't handle well pw_buffer's that contain only cursor metadata. Things work fine in obs and chromium."

Jan, would you mind taking a look?

S2 because the screenshot in the KDE bug indicates we're reading bad memory.
Sec-bug because we could be leaking unrelated memory to content this way.

Group: media-core-security
Severity: -- → S2
Status: UNCONFIRMED → NEW
Component: WebRTC → WebRTC: Audio/Video
Ever confirmed: true
Flags: needinfo?(jgrulich)
OS: Unspecified → Linux

Sure, I will look into this once I'm back from vacation (on Thursday). I'm surprised it works in Chromium since the code for screen sharing should be identical. Unless https://bugzilla.mozilla.org/show_bug.cgi?id=1896575 fixes it, because it was backported to M126 in Chromium and therefore released recently, while in Firefox it's only in FF 128 and thus not released yet.

Flags: needinfo?(jgrulich)

Sounds relevant! Martin, could you test in >= 128, i.e beta/nightly?

Flags: needinfo?(martin)
Attached image ff 127 vs 128b7

Just tried side by side ff 127 / 128b7, and indeed in 128b7 it doesn't happen, and the cursor moves correctly.

Flags: needinfo?(martin)

Great, thanks for confirming.

Status: NEW → RESOLVED
Closed: 5 months ago
Duplicate of bug: 1896575
Resolution: --- → DUPLICATE
Group: media-core-security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: