1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

As a follow up to Bug 1901261, we'll remove the existing default bookmarks in the bookmarks toolbar.
We will keep the translated strings for use in bookmarks toolbar button messages.

default-bookmarks.html
default-bookmarks.ftl

Comment 1

[Meg Viar [:mviar]]

Confirmed we'll want to remove the defaults from all builds.

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1904630 - Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab233ce47da1
Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers

Comment 4

[tszentpeteri]

Backed out for causing mochitest failures on browser_ext_contextMenus.js

• Backout link
• Push with failures
• Failure Log:

[task 2024-07-09T14:48:58.728Z] 14:48:58     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_contextMenus.js | menu item gamma found - 
[task 2024-07-09T14:48:58.729Z] 14:48:58     INFO - Console message: [JavaScript Error: "sendRemoveListener on closed conduit {c76bc691-0028-472a-86ec-ba7177f04da1}.137438954506" {file: "resource://gre/modules/ConduitsChild.sys.mjs" line: 122}]
[task 2024-07-09T14:48:58.730Z] 14:48:58     INFO - _send@resource://gre/modules/ConduitsChild.sys.mjs:122:13
[task 2024-07-09T14:48:58.731Z] 14:48:58     INFO - removeListener@resource://gre/modules/ExtensionChild.sys.mjs:673:34
[task 2024-07-09T14:48:58.732Z] 14:48:58     INFO - removeListener@resource://gre/modules/ExtensionChild.sys.mjs:929:40
[task 2024-07-09T14:48:58.732Z] 14:48:58     INFO - getAPI/register/api.menus.onClicked@chrome://browser/content/child/ext-menus.js:291:21
[task 2024-07-09T14:48:58.733Z] 14:48:58     INFO - removeListener@resource://gre/modules/ExtensionCommon.sys.mjs:2959:7
[task 2024-07-09T14:48:58.734Z] 14:48:58     INFO - revoke@resource://gre/modules/ExtensionCommon.sys.mjs:2981:12
[task 2024-07-09T14:48:58.735Z] 14:48:58     INFO - close@resource://gre/modules/ExtensionCommon.sys.mjs:2986:10
[task 2024-07-09T14:48:58.736Z] 14:48:58     INFO - unload@resource://gre/modules/ExtensionCommon.sys.mjs:1019:11
[task 2024-07-09T14:48:58.736Z] 14:48:58     INFO - unload@resource://gre/modules/ExtensionPageChild.sys.mjs:281:11
[task 2024-07-09T14:48:58.737Z] 14:48:58     INFO - unload@resource://gre/modules/ExtensionPageChild.sys.mjs:324:11
[task 2024-07-09T14:48:58.738Z] 14:48:58     INFO - destroyExtensionContext@resource://gre/modules/ExtensionPageChild.sys.mjs:496:15
[task 2024-07-09T14:48:58.739Z] 14:48:58     INFO - observe@resource://gre/modules/ExtensionPageChild.sys.mjs:397:12
[task 2024-07-09T14:48:58.741Z] 14:48:58     INFO - 
[task 2024-07-09T14:48:58.742Z] 14:48:58     INFO - Console message: [JavaScript Error: "sendRemoveListener on closed conduit {43e87048-b5d1-4f58-bc76-5208abdfce19}.137438954509" {file: "resource://gre/modules/ConduitsChild.sys.mjs" line: 122}]
[task 2024-07-09T14:48:58.742Z] 14:48:58     INFO - _send@resource://gre/modules/ConduitsChild.sys.mjs:122:13
[task 2024-07-09T14:48:58.743Z] 14:48:58     INFO - removeListener@resource://gre/modules/ExtensionChild.sys.mjs:673:34
[task 2024-07-09T14:48:58.744Z] 14:48:58     INFO - removeListener@resource://gre/modules/ExtensionChild.sys.mjs:929:40
[task 2024-07-09T14:48:58.745Z] 14:48:58     INFO - getAPI/register/api.menus.onClicked@chrome://browser/content/child/ext-menus.js:291:21
[task 2024-07-09T14:48:58.746Z] 14:48:58     INFO - removeListener@resource://gre/modules/ExtensionCommon.sys.mjs:2959:7
[task 2024-07-09T14:48:58.746Z] 14:48:58     INFO - revoke@resource://gre/modules/ExtensionCommon.sys.mjs:2981:12
[task 2024-07-09T14:48:58.747Z] 14:48:58     INFO - close@resource://gre/modules/ExtensionCommon.sys.mjs:2986:10
[task 2024-07-09T14:48:58.748Z] 14:48:58     INFO - unload@resource://gre/modules/ExtensionCommon.sys.mjs:1019:11
[task 2024-07-09T14:48:58.749Z] 14:48:58     INFO - unload@resource://gre/modules/ExtensionPageChild.sys.mjs:281:11
[task 2024-07-09T14:48:58.750Z] 14:48:58     INFO - unload@resource://gre/modules/ExtensionPageChild.sys.mjs:324:11
[task 2024-07-09T14:48:58.750Z] 14:48:58     INFO - destroyExtensionContext@resource://gre/modules/ExtensionPageChild.sys.mjs:496:15
[task 2024-07-09T14:48:58.751Z] 14:48:58     INFO - observe@resource://gre/modules/ExtensionPageChild.sys.mjs:397:12
[task 2024-07-09T14:48:58.752Z] 14:48:58     INFO - 
[task 2024-07-09T14:48:58.753Z] 14:48:58     INFO - Leaving test bound testRemoveAllWithTwoExtensions
[task 2024-07-09T14:48:58.754Z] 14:48:58     INFO - Entering test bound test_bookmark_contextmenu
[task 2024-07-09T14:48:58.754Z] 14:48:58     INFO - Buffered messages logged at 14:47:31
[task 2024-07-09T14:48:58.755Z] 14:48:58     INFO - Console message: [JavaScript Warning: "Password fields present on an insecure (http://) page. This is a security risk that allows user login credentials to be stolen." {file: "http://mochi.test:8888/browser/browser/components/extensions/test/browser/context.html" line: 0 column: 0 source: "0"}]
[task 2024-07-09T14:48:58.756Z] 14:48:58     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "http://mochi.test:8888/browser/browser/components/extensions/test/browser/context_frame.html" line: 0}]
[task 2024-07-09T14:48:58.757Z] 14:48:58     INFO - Buffered messages finished
[task 2024-07-09T14:48:58.758Z] 14:48:58     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_contextMenus.js | Test timed out - 
[task 2024-07-09T14:48:58.759Z] 14:48:58     INFO - GECKO(1059) | Completed ShutdownLeaks collections in process 1059
[task 2024-07-09T14:48:58.759Z] 14:48:58     INFO - TEST-START | Shutdown

Comment 5

[Meg Viar [:mviar]]

Thanks for flagging, I'll investigate this failure.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bccc4faa349a
Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers,extension-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc perma failures @ browser/components/extensions/test/browser/browser_ext_menus.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8e97ddad28d956d76a4ba65231f43ebfe619ac93

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_menus.js | Test timed out

Comment 8

[Meg Viar [:mviar]]

Thanks, I was able to reproduce on my Windows machine and have a fix.

Comment 9

[Meg Viar [:mviar]]

I'm landing again with the failure above addressed. The one remaining failure I see that's not intermittent is browser/base/content/test/performance/browser_startup_mainthreadio.js, but after running a try job with the commit landing here removed I see the same failure (try with the commit | try without).

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90819edf9bf2
Remove existing default bookmarks in toolbar to be replaced by a bookmark style configurable messaging surface r=places-reviewers,nalexander,Standard8,fluent-reviewers,flod,tabbrowser-reviewers,extension-reviewers

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/90819edf9bf2

Comment 12

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified this enhancement and I can confirm that only the "Import bookmarks..." button is displayed in the "Bookmarks" toolbar.

Verified using the latest Firefox Nightly 131.0a1 (Build ID: 20240821160637) and latest Firefox Beta 130.0b8 (Build ID: 20240821091813) on Windows 10 x64, macOS 14.1.1, and Ubuntu 22.04 x64.