1904645 - gcs-cli.py can't delete buckets if there are more than 256 objects

Status: RESOLVED FIXED

(Socorro :: General, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a local dev environment, if you try to delete a gcs bucket that has more than 256 objects in the gcs emulator with bin/gcs-cli.py, it kicks up this error:

  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/bin/gcs_cli.py", line 77, in delete_bucket
    bucket.delete(force=True)
  File "/usr/local/lib/python3.11/site-packages/google/cloud/storage/bucket.py", line 1585, in delete
    raise ValueError(message)
ValueError: Refusing to delete bucket with more than 256 objects. If you actually want to delete this bucket, please delete the objects yourself before calling Bucket.delete().

There's no way to delete individual objects with gcs-cli.py.

It should probably delete all the objects and then delete the bucket.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P2 because without this, we can't rebuild the local dev environment without wiping out docker state for the gcs emulator container.

Comment 2

[Daniel Thorn [:relud]]

Attachment: [mozilla-services/socorro] bug-1904645: fix gcs_cli.py deleting buckets with more than 256 objects (#6667)

Comment 3

[Daniel Thorn [:relud]]

relud merged PR [mozilla-services/socorro]: bug-1904645: fix gcs_cli.py deleting buckets with more than 256 objects (#6667) in 10c40f9.