1904702 - Substantial increase in startup metrics sending null values

Status: RESOLVED FIXED

(Fenix :: Experimentation and Telemetry, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: Redash graph depicting the large number of null values.png

Data science observed a large increase in null values being sent from some metrics (this query in particular is for preferences_signed_in_sync) that are set during startup. After some investigation, this seems to have been caused by the changes in bug 1892230.

At the same time, these metrics have also had the incorrect lifetime on them which has made them susceptible to data loss because of the new behaviour in batch writing within glean.

Device information

• Firefox version: 127
• Android device model: all devices
• Android OS version: all versions

Any additional information?

See the attached image on the linked query returning higher null values.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 1904702 - Update startup metrics to use an application lifetime r=#android-reviewers,janerik!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f3bdf3bffdd
Update startup metrics to use an application lifetime r=janerik,android-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0f3bdf3bffdd

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jonalmeida, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 9409553 [details]
Bug 1904702 - Update startup metrics to use an application lifetime r=#android-reviewers,janerik!

Beta/Release Uplift Approval Request

• User impact if declined: None, this does not affect users at all.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It only affects telemetry startup metric collection. The change is only in the metrics configuration and should not change the behaviour of the application.
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 9409553 [details]
Bug 1904702 - Update startup metrics to use an application lifetime r=#android-reviewers,janerik!

The same information in comment 5 can be used for the release request.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9409553 [details]
Bug 1904702 - Update startup metrics to use an application lifetime r=#android-reviewers,janerik!

128 is in RC now, moving the request accordingly.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9409553 [details]
Bug 1904702 - Update startup metrics to use an application lifetime r=#android-reviewers,janerik!

Approved for 128.0rc2.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/f25f6d109327