1904773 - Text-Fragments: Implement makeshift user-involvement

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P2)

Description

[Jan Jaeschke [:jjaschke]]

After implementing user activation in bug 1888756, text fragments are not scrolled to anymore if initiated by browser chrome (eg. pasting a link that contains a fragment directive into the url bar and hitting enter).

Even though user involvement is not implemented (tracked in bug 1901045), it is fairly easy to check if the current load is triggered by browser chrome: If the triggering principal is the system principal, the load is triggered from browser chrome.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1904773 - Text Fragments: Implemented makeshift user involvement check. r=edgar!,#dom-core

User involvement as defined in the spec is not implemented in Gecko yet.
Therefore, the changes introduced in Bug 1888756 disallowed scrolling to text directives if the load was triggered by the user, eg. by pasting a link with a text fragment into the url bar.

This patch checks if the triggering principal of the load is the system principal.
This is equivalent to the "browser UI" value of user involvement.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbe921345853
Text Fragments: Implemented makeshift user involvement check. r=edgar,dom-core,frontend-codestyle-reviewers

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dbe921345853