1904802 - .title icon in info-pages may be cropped

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Screenshot of cropped info icon in about:blocked

Hi, this is something we noticed in Tor Browser on linux.

If I visit a page styled with "info-page.css" and uses an icon, the icon will be cropped at its base. E.g. using the URL "about:blocked?e=deceptiveBlocked&u=example.org".

The problem is that the .title background icon is styled to be 1.6em tall, but there is no guarantee that the .title-text is tall enough to fit this.

This would be fixed by adding min-height: 1.6em to the .title block.

NOTE: I noticed this in Tor Browser based on Firefox 128, but not in my Firefox 128 build. I think the difference is that Tor Browser forces "Arimo" font, rather than the "Cantarell" font that my Firefox build uses, which creates a 3px difference. But I imagine this could also be a problem in Firefox, depending on the font being used.

Since this is such a small change, I'll write the patch myself and submit it now.

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1904802 - Ensure info-pages .title is tall enough for icon. r=#desktop-theme-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc193ebdcd02
Ensure info-pages .title is tall enough for icon. r=desktop-theme-reviewers,dao

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fc193ebdcd02

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Comment on attachment 9409671 [details]
Bug 1904802 - Ensure info-pages .title is tall enough for icon. r=#desktop-theme-reviewers

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: 128 is effected as well, the fix is small and should be simple to backport.
• User impact if declined: The icon on "info" pages may be clipped, depending on the page font.
• Fix Landed on Version: 129
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small risk since it just applies a single minor CSS rule.

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9409671 [details]
Bug 1904802 - Ensure info-pages .title is tall enough for icon. r=#desktop-theme-reviewers

Approved for 128.1esr.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/cb3bc72c1a82