1904829 - Editing the hidden scheme in the address bar behaves inconsistently

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Simon Friedberger (:simonf)]

In the current Nightly, when I edit an address in the address bar and I press Home the scheme appears. Sometimes it immediately appears, sometimes I have to press e.g. Left-Arrow for it to appear. When I press quickly press Home twice it never appears anymore.

Comment 1

[Marco Bonardo [:mak]]

(In reply to Simon Friedberger (:simonf) from comment #0)

In the current Nightly, when I edit an address in the address bar and I press Home the scheme appears. Sometimes it immediately appears, sometimes I have to press e.g. Left-Arrow for it to appear. When I press quickly press Home twice it never appears anymore.

Could you please tell me more about your system and the steps to reproduce the problem?
Which OS are you using?
How are you focusing the address bar before pressing Home? Clicking with the mouse, with a keyboard shortcut?
Which steps are more commonly causing the problem, do you just quickly press Home twice?
A screencast showing the bug may also be useful to better understand what happens, if you could capture it easily.

Comment 2

[Malte Jürgens [:maltejur]]

Attachment: Screencast_20240626_160703.webm

I can reproduce this on Wayland Linux and have attached a screen recording. This is what I did:

1. Click in the address bar
2. Hold the HOME key for 1s
3. Move around with the arrow keys and type text

This does not seem to happen if I just press the HOME key quickly, or double press it. But I suspect that holding the key also triggers some sort of double press due to keyboard repetition.

Comment 3

[Marco Bonardo [:mak]]

Holding down HOME is indeed reproducing the problem.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1904829 - Don't handle repeated keydown in urlbar handler. r=jteow

Avoid handling repeated keydown events in the urlbar handler as they are not
necessary and confuse our bookkeeping.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcfaeca37f65
Don't handle repeated keydown in urlbar handler. r=urlbar-reviewers,dao

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dcfaeca37f65

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mak, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.