1904870 - Use nsIHttpChannelInternal setResponseOverride for local script override

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Julian Descottes [:jdescottes]]

At the moment, local script override relies on redirecting channels to a data URI.
With nsIHttpChannelInternal's setOverrideResponse, we can provide a response body which will be treated as if it was served from the network.
Thanks to this, we can use it for more than scripts, and we should be able to override html, stylesheets, etc...

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1904870 - [devtools] Extract helper from NetworkObserver to compute timings

Depends on D217027

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1904870 - [devtools] Use setReplacedHttpResponse for local override

Depends on D217028

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1904870 - [devtools] Add test for local script override with CSP

Depends on D217029

Comment 4

[Julian Descottes [:jdescottes]]

Recently I often ran into websites with CSP directives for script which forbid data: usage, making the current local override feature unusable. So it might be worth switching to the new approach on that sole basis.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c43270a35465
[devtools] Extract helper from NetworkObserver to compute timings r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/03568d5fac4b
[devtools] Use setReplacedHttpResponse for local override r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/3bde83aa76ea
[devtools] Add test for local script override with CSP r=devtools-reviewers,bomsy

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c43270a35465
https://hg.mozilla.org/mozilla-central/rev/03568d5fac4b
https://hg.mozilla.org/mozilla-central/rev/3bde83aa76ea