1904917 - [wpt-sync] Sync PR 46915 - Remove unnecessary awaits from Attribution Reporting WPT

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46915 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46915
Details from upstream follow.

Andrew Paseltiner <[e-mail]> wrote:

Remove unnecessary awaits from Attribution Reporting WPT

The registerAttributionSrc helper function returned a promise
corresponding to completion of the various requests it can send, but in
general that completion is irrelevant to the behavior of these tests,
which previously used them to orchestrate a source registration
finishing before a trigger registration.

Unfortunately, completion of the request has no bearing on completion
of the response handling in the browser when the source and trigger
registrations occur in different redirect chains.

As such, the corresponding awaits were meaningless at best. Instead,
tests covering the behavior of source and trigger registrations in
separate redirect chains need to use the waitForSourceToBeRegistered
helper, which polls the server for verbose debug reports corresponding
to successful source registration.

Separately, it's not necessary to wait for a trigger registration to
complete beore polling reports.

In a followup change I will consolidate separate redirect chains where
that behavior is not specifically being tested.

Bug: 349397580, 349011165, 348594906
Change-Id: Id2e79525257567fd3bcb2249188fb04de2e43b3f
Reviewed-on: https://chromium-review.googlesource.com/5659020
WPT-Export-Revision: d6dd4db639b2d254e108284352af10ee1a0188ac

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b56db28ddc0033b3214191b746787152b73921e6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 23 tests and 1 subtests

Status Summary

Firefox

OK : 18
PASS : 2
FAIL : 16
TIMEOUT: 10

Chrome

OK : 18
PASS : 18
TIMEOUT: 10

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /attribution-reporting/aggregatable-debug/simple-source-aggregatable-debug-report.sub.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT)
  • Aggregatable debug report is received.: TIMEOUT (Chrome: TIMEOUT)
• /attribution-reporting/aggregatable-debug/simple-trigger-aggregatable-debug-report.sub.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT)
  • Aggregatable debug report is received.: TIMEOUT (Chrome: TIMEOUT)
• /attribution-reporting/aggregatable-report-no-contributions.sub.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT)
  • Aggregatable report is not created due to no contributions.: TIMEOUT (Chrome: TIMEOUT)
• /attribution-reporting/header-parsing-error-debug-report.sub.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT)
  • Header error debug report is received.: TIMEOUT (Chrome: TIMEOUT)
• /attribution-reporting/referrer-policy.sub.https.html?method=script [wpt.fyi]
  • attributionsrc referrer policy is propagated.: FAIL (Chrome: PASS)
• /attribution-reporting/referrer-policy.sub.https.html?method=a&noreferrer [wpt.fyi]
  • attributionsrc referrer policy is propagated.: FAIL (Chrome: PASS)
• /attribution-reporting/referrer-policy.sub.https.html?method=open [wpt.fyi]
  • attributionsrc referrer policy is propagated.: FAIL (Chrome: PASS)
• /attribution-reporting/referrer-policy.sub.https.html?method=img&noreferrer [wpt.fyi]
  • attributionsrc referrer policy is propagated.: FAIL (Chrome: PASS)
• /attribution-reporting/referrer-policy.sub.https.html?method=a [wpt.fyi]
  • attributionsrc referrer policy is propagated.: FAIL (Chrome: PASS)
• /attribution-reporting/referrer-policy.sub.https.html?method=open&noreferrer [wpt.fyi]
  • attributionsrc referrer policy is propagated.: FAIL (Chrome: PASS)
• /attribution-reporting/referrer-policy.sub.https.html?method=script&noreferrer [wpt.fyi]
  • attributionsrc referrer policy is propagated.: FAIL (Chrome: PASS)
• /attribution-reporting/referrer-policy.sub.https.html?method=img [wpt.fyi]
  • attributionsrc referrer policy is propagated.: FAIL (Chrome: PASS)
• [/attribution-reporting/request-format.sub.https.html?method=img&eligible&expected-eligible=event-source, trigger](https://wpt.live/attribution-reporting/request-format.sub.https.html?method=img&eligible&expected-eligible=event-source, trigger) [[wpt.fyi](https://wpt.fyi/results/attribution-reporting/request-format.sub.https.html?method=img&eligible&expected-eligible=event-source, trigger)]
  • attributionsrc request has the proper format.: FAIL (Chrome: PASS)
• /attribution-reporting/request-format.sub.https.html?method=fetch&eligible={"eventSourceEligible":true,"triggerEligible":false}&expected-eligible=event-source [wpt.fyi]
  • attributionsrc request has the proper format.: FAIL (Chrome: PASS)
• [/attribution-reporting/request-format.sub.https.html?method=script&eligible&expected-eligible=event-source, trigger](https://wpt.live/attribution-reporting/request-format.sub.https.html?method=script&eligible&expected-eligible=event-source, trigger) [[wpt.fyi](https://wpt.fyi/results/attribution-reporting/request-format.sub.https.html?method=script&eligible&expected-eligible=event-source, trigger)]
  • attributionsrc request has the proper format.: FAIL (Chrome: PASS)
• /attribution-reporting/request-format.sub.https.html?method=open&expected-eligible=navigation-source [wpt.fyi]
  • attributionsrc request has the proper format.: FAIL (Chrome: PASS)
• /attribution-reporting/request-format.sub.https.html?method=a&expected-eligible=navigation-source [wpt.fyi]
  • attributionsrc request has the proper format.: FAIL (Chrome: PASS)
• [/attribution-reporting/request-format.sub.https.html?method=img&expected-eligible=event-source, trigger](https://wpt.live/attribution-reporting/request-format.sub.https.html?method=img&expected-eligible=event-source, trigger) [[wpt.fyi](https://wpt.fyi/results/attribution-reporting/request-format.sub.https.html?method=img&expected-eligible=event-source, trigger)]
  • attributionsrc request has the proper format.: FAIL (Chrome: PASS)
• /attribution-reporting/request-format.sub.https.html?method=xhr&eligible={"eventSourceEligible":true,"triggerEligible":false}&expected-eligible=event-source [wpt.fyi]
  • attributionsrc request has the proper format.: FAIL (Chrome: PASS)
• [/attribution-reporting/request-format.sub.https.html?method=script&expected-eligible=event-source, trigger](https://wpt.live/attribution-reporting/request-format.sub.https.html?method=script&expected-eligible=event-source, trigger) [[wpt.fyi](https://wpt.fyi/results/attribution-reporting/request-format.sub.https.html?method=script&expected-eligible=event-source, trigger)]
  • attributionsrc request has the proper format.: FAIL (Chrome: PASS)
• /attribution-reporting/simple-verbose-debug-report.sub.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT)
  • Verbose debug report is received.: TIMEOUT (Chrome: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/217f5d814521
[wpt PR 46915] - Remove unnecessary awaits from Attribution Reporting WPT, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/217f5d814521