1905028 - [wpt-sync] Sync PR 46905 - Load external @page margin box resources.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46905 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46905
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Load external @page margin box resources.

First of all, trigger loading when computing @page margin box style,
just like we already do for @page properties in StyleForPage().

Secondly, attempt to make sure that the resources actually have loaded
before entering print mode. This was already working for @page
properties, and for regular document contents, but not for @page margin
boxes styles. Move the logic into StyleResolver, rather than keeping it
in Document::InitiateStyleOrLayoutDependentLoadForPrint().

Bug: 40341678, 341947679
Change-Id: I553d1c358614b460710975d47e6edd0f4e8f90d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649256
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Morten Stenshorne \<[e-mail]>
Reviewed-by: Traian Captan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1319694}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1934d686b548dc73b61dfe04e76eea80633a4a74

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests

Status Summary

Firefox

FAIL: 2

Chrome

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-page/margin-boxes/background-001-print.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /css/css-page/margin-boxes/content-003-print.html [wpt.fyi]: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d15583f579ff
[wpt PR 46905] - Load external @page margin box resources., a=testonly
https://hg.mozilla.org/integration/autoland/rev/41daf49c0fa6
[wpt PR 46905] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d15583f579ff
https://hg.mozilla.org/mozilla-central/rev/41daf49c0fa6