1905065 - IA2_TEXT_OFFSET_CARET should return nothing for IA2_TEXT_BOUNDARY_CHAR when caret at end of line

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

STR (with NVDA alpha):

1. Open this test case:
   data:text/html,<textarea cols="2">ab cd</textarea>
2. Focus the textarea.
3. Press the end key.
   • Expected: NVDA says "blank"
   • Actual: NVDA says "c"

I fixed this as part of bug 1901457. However, I didn't realise at the time that this regression would have impact beyond that bug.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 855184

Comment 2

[James Teh [:Jamie]]

However, we should not land this on beta without bug 1905021 as well because this bug 1905065 is preventing that more egregious bug from happening on beta. 😩

Edit: Actually, bug 1905021 existed long before Firefox 128, so we can address it separately on its own merits.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1905065: When a caret is at the end of a line, have TextLeafPoint::FindBoundary return no character for BOUNDARY_CLUSTER.

We already did this for BOUNDARY_CHAR, but i neglected to update this for cluster in bug 855184.
Without this, FindBoundary with BOUNDARY_CLUSTER on a caret TextLeafPoint when the caret is at the end of a line would return the last cluster instead of no character.

Comment 4

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Incorrect character read by some screen readers when moving to the end of a line.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: NA
• Risk associated with taking this patch: low
• Explanation of risk level: Very simple patch covered by automated tests.
• String changes made/needed: none
• Is Android affected?: no

Comment 5

[James Teh [:Jamie]]

Attachment: Bug 1905065: Add test.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1aafb20c310
Add test. r=nlapre

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b1aafb20c310

Comment 8

[James Teh [:Jamie]]

Attachment: Bug 1905065: Add test.

Original Revision: https://phabricator.services.mozilla.com/D215179

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: None. This is just an automated test for the first patch on this bug.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: NA
• Risk associated with taking this patch: low
• Explanation of risk level: Test only.
• String changes made/needed: none
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a3a720d3c849
https://hg.mozilla.org/releases/mozilla-beta/rev/e9a01d1186e3