1905083 - "browsingContext.navigate" has to return "unknown error" if navigation failed

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Step 7 of await a navigation describes that a navigation needs to fail with unknown error if the navigation status is canceled - like it can happen when dismissing a beforeunload prompt.

Before we can get started to work on this bug we need the browsingContext.navigationFailed event first (bug 1846601).

Comment 1

[Julian Descottes [:jdescottes]]

Bug 1846601 is being implemented at the moment, would be nice to handle this one as a follow up if we have time during m12.

Comment 2

[Alexandra Borovova [:Sasha]]

It would be good in the scope of this bug to also take a look if it's possible or how hard it's to implement the logic to return a more meaningful error message in case the navigation fails because of the error returned from the platform. Maybe we could reuse some devtools code or create some shared logic.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1905083 - [bidi] Fail "browsingContext.navigate" command when the "navigation-failed" event received.

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1905083 - [wdspec] Add tests for error cases of "browsingContext.navigate" command.

Comment 5

[Alexandra Borovova [:Sasha]]

(In reply to Alexandra Borovova [:Sasha] from comment #2)

It would be good in the scope of this bug to also take a look if it's possible or how hard it's to implement the logic to return a more meaningful error message in case the navigation fails because of the error returned from the platform. Maybe we could reuse some devtools code or create some shared logic.

This part is moved to follow-up (bug 1912400).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57b35acde62f
[bidi] Fail "browsingContext.navigate" command when the "navigation-failed" event received. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/cc92c2f19204
[wdspec] Add tests for error cases of "browsingContext.navigate" command. r=webdriver-reviewers,jdescottes

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47540 for changes under testing/web-platform/tests

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/57b35acde62f
https://hg.mozilla.org/mozilla-central/rev/cc92c2f19204

Comment 9

[Atila Butkovits]

Backed out for causing for causing Bug 1912554.

Backout link: https://hg.mozilla.org/integration/autoland/rev/34c818c2ef3596690c0815c842bd0684b4d37df6

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=LplrG6smSMeOHHUUTgwbjg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=wd&revision=c948d8669436eb2562acc2dfd11f384fcc5d3772

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=469924298&repo=autoland&lineNumber=106565
https://treeherder.mozilla.org/logviewer?job_id=469941827&repo=mozilla-central&lineNumber=107224

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1905083 - Add LSAN failure to allow list.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3322352a66d6
[bidi] Fail "browsingContext.navigate" command when the "navigation-failed" event received. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/e7b46e8452ee
[wdspec] Add tests for error cases of "browsingContext.navigate" command. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/d6419e91d310
Add LSAN failure to allow list. r=webdriver-reviewers,whimboo

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3322352a66d6
https://hg.mozilla.org/mozilla-central/rev/e7b46e8452ee
https://hg.mozilla.org/mozilla-central/rev/d6419e91d310

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot