1905107 - Crash in [@ TppRaiseInvalidParameter]

Status: RESOLVED WORKSFORME

(External Software Affecting Firefox :: Other, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

In the last two weeks, we have observed an increase in crash volume for this signature. The reports I read are all about external DLL files in the stacks

• weasel.dll e.g. bp-94292f5f-d494-40ba-b94a-ea3070240626 - related to RIME input method engine https://github.com/rime/weasel
• sgephook.dll e.g. bp-9a1e3060-1fa5-4b0d-b206-ab9e70240626 - by Beijing SkyGuard Cybersecurity Technology Co., Ltd. They offer a data loss prevention provider (DLP) https://www.skyguard.com.cn/en/
• f_webff.dll e.g. bp-f89b36d3-a47b-4924-a251-602ca0240613, likely also a DLP https://en.fasoo.com/

Crash report: https://crash-stats.mozilla.org/report/index/94292f5f-d494-40ba-b94a-ea3070240626

Reason: STATUS_INVALID_PARAMETER

Top 10 frames:

0  ntdll.dll  TppRaiseInvalidParameter
1  ntdll.dll  TpAllocWork
2  kernel32.dll  CreateThreadpoolWorkStub
3  weasel.dll  weasel.dll@0x464af
4  weasel.dll  weasel.dll@0xeb8f
5  weasel.dll  weasel.dll@0xe8dc
6  weasel.dll  weasel.dll@0x91227
7  weasel.dll  weasel.dll@0xf8c7
8  weasel.dll  weasel.dll@0x13e30
9  weasel.dll  weasel.dll@0xb9eef

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The changes in bug 1898718 and bug 1899703 are about DLP and shutdown hangs.

Comment 2

[Greg Stoll :gstoll]

Those are for the DLP SDK, which to our knowledge no one is using yet. (also the stacks for the shutdown hangs in those cases look different)

Comment 3

[Greg Stoll :gstoll]

As of today the vast majority of these crashes over the last 7 days are from weasel.dll (69 vs. 5 with f_webff.dll and 1 with sgephook.dll). So I'm going to focus on that.

Comment 4

[Greg Stoll :gstoll]

This only seems to happen with version 0.16.1 of rime and appears to match issue 1286 in their GitHub repo.

Comment 5

[Greg Stoll :gstoll]

Somehow I missed that this is a crash on startup. Looks like this can happen when we're exiting after applying updates, or when we're exiting quickly for some other reason. I have a reasonable-looking stack trace with weasel.dll symbols resolved, so I'm going to post to that thread with more information.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 desktop browser crashes on nightly

:gstoll, could you consider increasing the severity of this top-crash bug?

For more information, please visit BugBot documentation.

Comment 7

[Greg Stoll :gstoll]

It looks like this PR may fix the issue. It went in a month ago, though, and there's no new release yet. I've pinged the maintainer on the existing issue to ask when a new release is coming.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signature linked to this bug is not a topcrash signature anymore.

For more information, please visit BugBot documentation.

Comment 9

[Gabriele Svelto [:gsvelto]]

I'm seeing a lot of these crashes with STGuard64.dll on the stack, like this one. I suppose this is a different crash than the original?

Comment 10

[Gabriele Svelto [:gsvelto]]

There are at least 4 distinct bugs lurking under this signature. I'll add TppRaiseInvalidParameter to Socorro's prefix list to unveil the contents of the second frame on the stack. This should be sufficient to unmask the different crashes, I'll then file each one in a separate bug.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.