1905119 - [Experiment] The UI elements of the Cookie Banner Reduction CFR message are wrongly displayed for RTL builds

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

Attachment: CFR CBB.jpg

[Affected versions]:

• Firefox Beta 128.0b8 - Build ID: 20240626091446

[Affected Platforms]:

• Windows 10 x64
• macOS 12.4
• Linux Ubuntu 20.04 x64

[Prerequisites]:

• Have a Firefox RTL build installed (ar, he, fa, etc).
• Have the following pref set:
  nimbus.debug = true

[Steps to reproduce]:

1. Open the browser from the prerequisites.
2. Copy and paste the following link in order to force enroll in the “CBB ROW Hold-back with Promo” experiment: about:studies?optin_slug=cbb-row-hold-back-with-promo&optin_branch=treatment-a&optin_collection=nimbus-preview
3. Restart the browser.
4. Open a new Private Window.
5. Navigate to a website that contains a cookie banner. (e.g. bloomberg.com, cnn.com)
6. Observe the CFR message.

[Expected result]:

• The elements of the CFR message are correctly displayed respecting the RTL rules.

[Actual result]:

• The message’s arrow points to the Address Bar instead of being anchored to the "Tracking Protections" button.
• The X button, cookie icon, link, and text from the message's content are displayed in the same way as on the LTR builds.
• The X button overlaps part of the text from the message’s content.

[Notes]:

• Attached is a screenshot of the issue on 3 RTL builds (ar, he, fa, etc).
• This issue is probably reproducible with other RTL builds.

Comment 1

[Shane Hughes [:aminomancer]]

Hi DJ, I think you own this CFR?

Comment 2

[Punam Dahiya [:pdahiya]]

Feature callout message added in tree here https://searchfox.org/mozilla-central/rev/6936c4c3fc9bee166912fce10104fbe0417d77d3/browser/components/asrouter/modules/FeatureCalloutMessages.sys.mjs#987

Message display is controlled via cookiebanners.ui.desktop.showCallout which is false by default and configurable to show via experiment

https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#3055
https://searchfox.org/mozilla-central/rev/6936c4c3fc9bee166912fce10104fbe0417d77d3/toolkit/components/nimbus/FeatureManifest.yaml#2884

Comment 3

[Meg Viar [:mviar]]

This message has custom margins that are likely responsible, so this may not be an issue with feature callouts in general.

Comment 4

[DJ (:dwalker) (on PTO until Apr 7)]

(In reply to Shane Hughes [:aminomancer] from comment #1)

Hi DJ, I think you own this CFR?

I recall working on this a while ago. We had to do these margin adjustments due to limitations in the feature callout template that weren't compatible with the doorhanger design. I think it would be best to either modify the feature callout to accomodate the UX needs, or re-evaluate the UX here to fall more in line with the existing messaging surfaces.

Comment 5

[Shane Hughes [:aminomancer]]

Attachment: Bug 1905119 - Fix feature callout RTL display. r=#omc-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa7ed837efc1
Fix feature callout RTL display. r=omc-reviewers,negin

Comment 7

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/fa7ed837efc1

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:aminomancer, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on Firefox Nightly 130.0a1 (Build ID: 20240718214749) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 14.4.1.

• The message’s arrow points to the "Tracking Protections" button.
• The X button, cookie icon, link, and text from the message's content mirror the LTR builds.
• The X button doesn’t overlap part of the text from the message’s content.

@Shane, we noticed that on the "ar" and "fa" builds, the text within the message is not translated accordingly (the strings are in English). Could it be because on Nightly there are no translations available for these locales?

Comment 11

[Shane Hughes [:aminomancer]]

(In reply to Carmen Fat [:cfat] - Ecosystem QA from comment #10)

@Shane, we noticed that on the "ar" and "fa" builds, the text within the message is not translated accordingly (the strings are in English). Could it be because on Nightly there are no translations available for these locales?

I think that's right. Here are the current translations, and I don't see ar or fa. Looks like there are others missing as well. I don't know when the planned launch is for this message or what locales it's targeting though.